[SRU] Fix missing forecast

[Amr Ibrahim]

[Impact]

 * Hours badly displayed in gnome-weather applet, missing forecasts

[Test Case]

 * install and use it, some items will be missing or offset-by-one displayed

[Regression Potential]

 * None, upstream fix backported

[Other Info]

From upstream bugzilla:
"There used to be an item for 2am in the forecast for tomorrow but now it's missing. There is also missing one item in the forecast for today. If it's 7am the forecast should start with item for 8am but it starts with item for 11am."

The fixing commit is attached and comes from upstream https://git.gnome.org/browse/gnome-weather/commit/?id=a295755fc8c893f2f837e8d62277915e50e3613d

Affects gnome-weather 3.18.1 on xenial.

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "fix-missing-forecast.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

[Tim Lunn (darkxst)]

Amir, please don't subscribe sponsors team, until there is a debdiff ready for upload. I would really suggest your try and package up this fix, it would be a good introduction to debian packaging for you!

ping me on #ubuntu-gnome on freenode IRC if you need help

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Amr Ibrahim (amribrahim1987)]

This is fixed in Yakkety.
Could we get the fix into Xenial? I think the fix is simple.

[Amr Ibrahim (amribrahim1987)]

How can I convert the attached patch into a debdiff?

[Ubuntu GNOME (ug-bot)]

Amr, you need to use quilt to apply the patch (see debian/patches/), update changelog and then rebuild a new debian package. Then you can generate a debdiff against the old version using debdiff

[Amr Ibrahim (amribrahim1987)]

Anyone could take over this bug.

[Gianfranco Costamagna (costamagnagianfranco)]

please test ppa:costamagnagianfranco/locutusofborg-ppa

[Brian Murray (brian-murray)]

Hello Amr, or anyone else affected,

Accepted gnome-weather into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-weather/3.18.1-1ubuntu1.16.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Gianfranco Costamagna (costamagnagianfranco)]

@Amr can you please test it?

[Gianfranco Costamagna (costamagnagianfranco)]

seems good to me

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-weather - 3.18.1-1ubuntu1.16.04.1

---------------
gnome-weather (3.18.1-1ubuntu1.16.04.1) xenial; urgency=medium

  * Cherry-pick upstream patch to fix a forecast issue
    - debian/patches/a295755fc8c893f2f837e8d62277915e50e3613d.patch:
      (LP: #1555911)

 -- Gianfranco Costamagna <email address hidden> Tue, 28 Feb 2017 12:41:52 +0100

[Brian Murray (brian-murray)]

The verification of the Stable Release Update for gnome-weather has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.