Please merge gramps (2.2.9-1) from Debian unstable (main)

Bug #155487 reported by Cesare Tirabassi
8
Affects Status Importance Assigned to Milestone
gramps (Ubuntu)
Fix Released
Wishlist
Unassigned

Bug Description

Binary package hint: gramps

Please merge gramps (2.2.9-1) from Debian unstable (main)

Changed in gramps:
importance: Undecided → Wishlist
status: New → Confirmed
Tiago Sousa (tiagoboldt)
Changed in gramps:
assignee: nobody → tiagoboldt
Tiago Sousa (tiagoboldt)
Changed in gramps:
status: Confirmed → In Progress
Revision history for this message
Tiago Sousa (tiagoboldt) wrote :

This has been my first attempt into something like this, so I'm not 100% sure if this is completely correct. But I hope it is :D

Changed in gramps:
assignee: tiagoboldt → ubuntu-universe-sponsors
status: In Progress → Confirmed
Revision history for this message
Cesare Tirabassi (norsetto) wrote :

You should:

1) Subscribe, not assign u-u-s
2) Make sure that your debdiffs are clean, ie. the debian to ubuntu patch must only contain those changes which are in the changelog.

Please subscribe again u-u-s once corrected.

Changed in gramps:
assignee: ubuntu-universe-sponsors → tiagoboldt
status: Confirmed → Incomplete
Revision history for this message
Nicolas Valcarcel (nvalcarcel) wrote :

What do you mean by u-u-s?

Revision history for this message
Scott Kitterman (kitterman) wrote : Re: [Bug 155487] Re: Please merge gramps (2.2.9-1) from Debian unstable (main)

ubuntu-universe-sponsors

Revision history for this message
Tiago Sousa (tiagoboldt) wrote :

It's the Ubuntu-Universe-Sponsors. They'll them process the patch.

Revision history for this message
Nicolas Valcarcel (nvalcarcel) wrote :

I have *tryed* to correct the sugestions, take a look please

Revision history for this message
Nicolas Valcarcel (nvalcarcel) wrote :

Fixing some problems.

Revision history for this message
Cesare Tirabassi (norsetto) wrote :

Nicolas,

I have not even opened your patches. Just look at the size of them and you will see something is wrong.
You can use the filterdiff command to filter out everything which is external to the /debian directory (see man filterdiff).

On the changelog:

This:

 - Updated many text/translations and help docs.

is not an ubuntu change, its an upstream change part of gramps (2.2.9-1)

This:

 - Modified debian/control according to Standards v3.7.2

is more correct as ScottK already did in his changelog:

 - Bumped standards version to 3.7.2 without further change

You have forgotten these changes:

 * Moved debhelper from Build-Depends-Indep to Build-Depends to satisfy
    lintian
 - debian/rules: Remove dh_python

This:

 - Removed deprecated dh_iconcache in favor of dh_icons

is correct, but you forgot to say that dh_iconcache was an ubuntu change. So, I would say something like:

- Re-add dh_iconcache in debian/rules but change it to dh_icons since dh_iconcache is being deprecated

Revision history for this message
Cesare Tirabassi (norsetto) wrote :

I forgot to mention, Tiago Sousa was working on this, so, don't hijack his work unless he has agreed.
If he agrees, than you have to ASSIGN it to yourself.
When you subscribe u-u-s you have to de-assign yourself and mark it as confirmed.

Revision history for this message
Tiago Sousa (tiagoboldt) wrote :

We've talked and since we're both first timers, I've decided to let him correct my mistakes. Keep it up Nicolas.

Revision history for this message
Cesare Tirabassi (norsetto) wrote :

Then please de-assign yourself to the bug and assign Nicolas.

Tiago Sousa (tiagoboldt)
Changed in gramps:
assignee: tiagoboldt → nxvl
Revision history for this message
Cesare Tirabassi (norsetto) wrote :

Beside filterdiff, you have two other options:

- use dad (http://dad.dunnewind.net/universe.php)
- do a manual merge

If I were you I would try them all, its very instructive anyhow.

Revision history for this message
Nicolas Valcarcel (nvalcarcel) wrote :

ok, fixed debdiff following the comments

Changed in gramps:
assignee: nxvl → nobody
status: Incomplete → Confirmed
Revision history for this message
Nicolas Valcarcel (nvalcarcel) wrote :

Fixing some problems.

Revision history for this message
Nicolas Valcarcel (nvalcarcel) wrote :

Sorry about last debdiff, newbie error

Changed in gramps:
assignee: nobody → kitterman
status: Confirmed → In Progress
Changed in gramps:
assignee: kitterman → nobody
status: In Progress → Fix Committed
Revision history for this message
Scott Kitterman (kitterman) wrote :

My bad on the bug number in debian/changelog. Sorry. Don't put Bug in there.

Changed in gramps:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.