Tagged journal entries with excluded tags missing some conditions

Bug #1551027 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Cecilia Vela Gurovic
16.10
Fix Released
Medium
Cecilia Vela Gurovic

Bug Description

Mahara master:

Journal entries tagged the following way:

1. cat, dog, monkey, elephant
2. cat, dog
3. cat, monkey, elephant
4. cat, dog, elephant

When you use the combination of
+cat -dog -monkey

The string in the block says: 'There are no journal entries tagged "cat"' but doesn't actually mention that there are two other conditions part of it and that's why no journal entries are displayed.

When the condition is +cat +dog, it says correctly: 'Journal entries with tag "cat" but not tag "dog" '

I think +cat -dog -monkey should read: Journal entries with tag "cat" but not tag "dog" and not tag "monkey"

Tags: bite-sized
no longer affects: mahara/15.10
no longer affects: mahara/16.04
tags: added: bite-sized
Revision history for this message
Cecilia Vela Gurovic (ceciliavg) wrote :

If the tags are only excluding, the block show wrong message.

For example:

With tags -elephant, -monkey, the block shows message

    Journal entries with tags but not tags "elephant", "monkey"

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/6957

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/6957
Committed: https://git.mahara.org/mahara/mahara/commit/6714784805eae980948f1c87efc80e8ed11782ac
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 6714784805eae980948f1c87efc80e8ed11782ac
Author: Cecilia Vela Gurovic <email address hidden>
Date: Mon Sep 12 16:46:14 2016 +1200

Bug 1551027: Corrected messages showed in a
Journal entries block filtered by tags

behatnotneeded

Change-Id: Idfb823d4babff47b192a7c1b6f0588d2e2e5545b

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "16.10_STABLE" branch: https://reviews.mahara.org/6982

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/6982
Committed: https://git.mahara.org/mahara/mahara/commit/ad53199b1d8201e3905620e3833ec1bec331a7dd
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.10_STABLE

commit ad53199b1d8201e3905620e3833ec1bec331a7dd
Author: Cecilia Vela Gurovic <email address hidden>
Date: Mon Sep 12 16:46:14 2016 +1200

Bug 1551027: Corrected messages showed in a
Journal entries block filtered by tags

behatnotneeded

Change-Id: Idfb823d4babff47b192a7c1b6f0588d2e2e5545b
(cherry picked from commit 6714784805eae980948f1c87efc80e8ed11782ac)

Robert Lyon (robertl-9)
Changed in mahara:
milestone: 16.04.1 → none
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.