[webapp-container] Header does not notice when theme-color changes
Bug #1550754 reported by
Michael Terry
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Canonical System Image |
Fix Released
|
Medium
|
David Barth | ||
| webbrowser-app (Ubuntu) |
Fix Released
|
Medium
|
Alexandre Abreu | ||
Bug Description
In my "reddit mobile" webapp (m.reddit.com), the header starts blue, because that is the theme-color of reddit. But some subreddits have their own theme-colors, and the header does not update to reflect that.
To reproduce, compare webapp-container results between m.reddit.com and m.reddit.
Related branches
lp:~abreu-alexandre/webbrowser-app/handle-theme-color-updates
- Alberto Mardegan (community): Approve
- PS Jenkins bot: Needs Fixing (continuous-integration)
-
Diff: 134 lines (+61/-13)3 files modifiedsrc/app/webcontainer/webapp-specific-page-metadata-collector.js (+13/-4)
tests/autopilot/webapp_container/tests/fake_servers.py (+30/-9)
tests/autopilot/webapp_container/tests/test_page_meta_collector.py (+18/-0)
| Changed in webbrowser-app (Ubuntu): | |
| status: | New → Confirmed |
| importance: | Undecided → Medium |
| assignee: | nobody → Alexandre Abreu (abreu-alexandre) |
| Changed in webbrowser-app (Ubuntu): | |
| status: | Confirmed → In Progress |
| Changed in canonical-devices-system-image: | |
| status: | New → Fix Committed |
| importance: | Undecided → Medium |
| assignee: | nobody → David Barth (dbarth) |
| milestone: | none → 11 |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #1 |
| Changed in webbrowser-app (Ubuntu): | |
| status: | In Progress → Fix Released |
| Changed in canonical-devices-system-image: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
This bug was fixed in the package webbrowser-app - 0.23+16.
---------------
webbrowser-app (0.23+16.
* Add --open-
(not part of patterns) are opened in overlays instead of external
browser (LP: #1548575)
* Handle live updates to theme color meta tag and reflect them in the
top bar background color (LP: #1550754)
* Set address bar text color to a darker version of the theme color if
one is defined in a webapp (LP: #1548573)
-- Alexandre Abreu <email address hidden> Tue, 05 Apr 2016 15:42:59 +0000