php packages: add php-xml dependencies

Bug #1549552 reported by Nish Aravamudan
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
phpunit (Ubuntu)
Fix Released
Low
Unassigned

Bug Description

Debian has split out php-xml into its own binary package and various src packages need to be updated to reference this new package as a dependency in order to build/test.

Tags: packaging
Revision history for this message
Nish Aravamudan (nacc) wrote :
Revision history for this message
Nish Aravamudan (nacc) wrote :
Revision history for this message
Nish Aravamudan (nacc) wrote :
Mathew Hodson (mhodson)
tags: added: packaging
Changed in phpab (Ubuntu):
importance: Undecided → Low
Changed in phpunit (Ubuntu):
importance: Undecided → Low
Changed in phpunit-dbunit (Ubuntu):
importance: Undecided → Low
Revision history for this message
Nish Aravamudan (nacc) wrote :
summary: - phpab: add php-xml dependencies
+ php packages: add php-xml dependencies
Changed in php-sabredav (Ubuntu):
importance: Undecided → Low
Changed in php-sabre-http (Ubuntu):
importance: Undecided → Low
no longer affects: php-sabredav (Ubuntu)
Revision history for this message
Nish Aravamudan (nacc) wrote :
Revision history for this message
Steve Langasek (vorlon) wrote :

phpunit uploaded (bug bug not closed in changelog).

Changed in phpunit (Ubuntu):
status: New → Fix Committed
Revision history for this message
Steve Langasek (vorlon) wrote :

For the remaining packages, please clarify why they need direct dependencies on php-xml, as opposed to picking this up via phpunit. If they only need it for phpunit, then this should be fixed once in the phpunit package only.

Revision history for this message
Steve Langasek (vorlon) wrote :

Ah, I see; your patch against phpunit adds php-xml as a build-dependency and a test dependency, but not as a binary dependency.

From what I see on autopkgtest, phpunit has a pretty strong dependency on DOMDocument. I am adding this as a binary dependency as well, to unbreak the various tests.

Revision history for this message
Nish Aravamudan (nacc) wrote :

@Steve, you're absolutely right. I just came to this realization on Sunday and was going to post a new debdiff today.

Also, note that for phpunit to get built/unblocked, we need the fix to php-defaults at Bug # 1549441 (https://bugs.launchpad.net/ubuntu/+source/php-defaults/+bug/1549441/+attachment/4582178/+files/php-defaults_32.32ubuntu1.debdiff). I realize now that I probably should file a new bug for that?

Revision history for this message
Steve Langasek (vorlon) wrote : Re: [Bug 1549552] Re: php packages: add php-xml dependencies

On Mon, Feb 29, 2016 at 03:59:08PM -0000, Nish Aravamudan wrote:
> @Steve, you're absolutely right. I just came to this realization on
> Sunday and was going to post a new debdiff today.

> Also, note that for phpunit to get built/unblocked, we need the fix to
> php-defaults at Bug # 1549441 (https://bugs.launchpad.net/ubuntu/+source
> /php-defaults/+bug/1549441/+attachment/4582178/+files/php-
> defaults_32.32ubuntu1.debdiff). I realize now that I probably should
> file a new bug for that?

Ah, that would have been better, but now that I've seen that debdiff I'll
pick it up from there.

NB I've modified the changelog to the following for clarity:

php-defaults (32ubuntu1) xenial; urgency=medium

  * Temporarily drop support for imap, interbase, mcrypt, and zip as their
    php7.0-* dependencies are currently not built due to universe
    build-dependencies. This change can be reverted after the php7
    transition as soon as these binary dependencies are available again.

 -- Nishanth Aravamudan <email address hidden> Fri, 26 Feb 2016 14:38:35 -0800

--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer http://www.debian.org/
<email address hidden> <email address hidden>

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package phpunit - 5.1.3-1+ubuntu3

---------------
phpunit (5.1.3-1+ubuntu3) xenial; urgency=medium

  * php-xml also needs to be a binary dependency. LP: #1549552.

 -- Steve Langasek <email address hidden> Sun, 28 Feb 2016 22:06:06 -0800

Changed in phpunit (Ubuntu):
status: Fix Committed → Fix Released
Nish Aravamudan (nacc)
no longer affects: php-sabre-dav-2.1 (Ubuntu)
no longer affects: php-sabre-http (Ubuntu)
no longer affects: phpab (Ubuntu)
no longer affects: phpunit-dbunit (Ubuntu)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.