Stale references to /lib/udev/rules.d/95-multipath.rules linger

[Tore Anderson]

/lib/udev/rules.d/95-multipath.rules was removed in multipath-tools 0.4.9-3ubuntu7.5.

While researching an unrelated issue, I noticed that /usr/share/initramfs-tools/hooks/multipath still refer to this file:

add_udev_rules()
{
  for rules in 95-multipath.rules; do
    if [ -e /lib/udev/rules.d/$rules ]; then
      cp -p /lib/udev/rules.d/$rules $DESTDIR/lib/udev/rules.d/
    fi
  done
}

This is dead code that it would probably be best to remove.

[Christian Ehrhardt  (paelzer)]

Thanks for finding this.

FYI - to have that still listed is actually a bug in the Debian packaging.
It is listed as 60-multipath.rules there.
We had a delta that modified the priority of that that I'll drop on the next merge.

To really remove it would need a Debian bug, would you mind reporting that to Debian to remove that on the next upgrade they do?

[Christian Ehrhardt  (paelzer)]

Looked into that again, and while the 60-kpartx existence still confuses me a bit I reported to Debian to drop the stale reference so we can pick it up next merge.
IMO we can drop even more related to that context.
I'll link the bug here.

[Christian Ehrhardt  (paelzer)]

The fix is actually a re-add of the rules we lost.

@cyphermox - I subscribed you since we need to consider asap if we want/need those rules for zesty (or even SRU some back?) - unfortunately I never "actively" cared what they do so far. And the references I found [1] quickly are not 100% clear what it is used for, so it is hard for me to decide.

[1]: https://patchwork.kernel.org/patch/6017721/

[Christian Ehrhardt  (paelzer)]

- default prio is 60 (see man dh_installudev) which is after 55
- 60-multipath.rules also is the name it is referenced in debian/initramfs/hooks in Debian
- Now delivered due to the Debian bug I opened since:
  commit 6b749a5251e12ed4da92de7b79ddf7ef15f343af
  Author: Ritesh Raj Sarraf <email address hidden>
  Date: Fri Mar 24 17:28:11 2017 +0530
    Ship multipath udev rules
- There was a minimal update since in the past the ship of that got removed (because the file
  wasn't moved into debian/*, that is updated and now should work in Debian and Ubuntu)
- Part of the upcoming merge, bug will auto-close once the merge is complete.

[Launchpad Janitor (janitor)]

This bug was fixed in the package multipath-tools - 0.6.4-5ubuntu1

---------------
multipath-tools (0.6.4-5ubuntu1) artful; urgency=medium

  * Merge from Debian. (LP: #1548303) Remaining changes:
    - d/control:
      - multipath-udeb: add sg3-udeb Depends
    - d/rules: Move udev rules to priority 95, because rules that load modules
      should be >90.
    - d/multipath-tools.preinst: modprobe dm-multipath; This will make sure
      that multipathd will be able to start.
    - Split kpartx initramfs bits into kpartx-boot for dmraid (LP 941874)
      - d/initramfs/kpartx.hook
      - d/kpartx-boot.postinst
      - d/kpartx-boot.postrm
      - d/control: Add kpartx-boot package for dmraid
      - d/rules: Install kpartx initramfs hook
      - d/kpartx.install: install all arch /lib* kpartx udev rules
    - patches to multipath source
      - d/p/1000--set-umask-in-multipathd.patch: Set umask in multipathd.
      - d/p/kpartx_more_loopback_fixes.patch: fix loopback mounted
        files some more: since we stat() the loopback device node, we can't rely
        on S_ISREG() tests to handle this case, and should look at the device
        itself instead. (LP 1543430)
      - d/p/enable-find-multipaths.patch: re-enable find_multipaths
        by default -- see the removed 'add_find-multipaths.patch' (LP 1463046)
   - multipath initramfs fixes for booting from multipathed devices
      - d/initramfs/hooks: also copy wwids file on the installed system to
        ensure all paths come up on boot. (LP 1479929)
      - d/initramfs/hooks: install multipathd and required directories.
      - d/initramfs/hooks: copy dm-mpath-lvm & multipath udev rules to initramfs
      - d/initramfs/hooks: do not copy kpartx rules to initramfs
      - d/initramfs/local-bottom: remember to stop multipathd.
      - d/initramfs/local-premount: wait for udev to settle before the call to
        resolve_device() in local_mount_root(), so the by-uuid/ symlinks have a
        chance to be updated by the multipath udev rules (LP 1503286).
      - d/initramfs/local-premount: Run multipath with -B so not to assign names
        nor change /etc/multipath/bindings during initramfs (LP 1561103)
      - d/rules: install d/initramfs/local-bottom
      - d/rules: install d/initramfs/local-premount
   - Disable -fexceptions on multipath-udeb (LP 1489379): the flag causes
     libchecktur.so to link with libgcc_s.so.1 (even with -static-libgcc),
     which is not available in the installer environment.
     - d/p/disable-fexceptions-udeb.patch: conditionally disable -fexceptions
       with CFLAGS_DISABLE_FEXCEPTIONS.
     - d/rules: set CFLAGS_DISABLE_FEXCEPTIONS to build multipath-udeb.
   - Remove partition device nodes of individual paths (for LVM on multipath)
     on the new multipath-tools with udev property blacklisting (LP 1540401)
     - d/multipath-tools.dm-mpath-lvm.udev: udev rule for that.
     - d/initramfs/init-top: load the dm-multipath module for
       'multipath -c'.
     - d/initramfs/init-top: start multipathd before udev (required by
       'multipath -u' in the udev rules)
     - d/rules: install the udev rule (priority 56: after 55-scsi-sg3_id)
     - d/rules:...