ZFS pools should be automatically scrubbed
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
zfs-linux (Ubuntu) |
Fix Released
|
Medium
|
Colin Ian King | ||
Xenial |
Fix Released
|
Medium
|
Unassigned |
Bug Description
[Impact]
Xenial shipped with a cron job to automatically scrub ZFS pools, as
desired by many users and as implemented by mdadm for traditional Linux
software RAID. Unfortunately, this cron job does not work, because it needs a PATH line for /sbin, where the zpool utility lives.
Given the existence of the cron job and various discussions on IRC, etc.,
users expect that scrubs are happening, when they are not. This means ZFS
is not pre-emptively checking for (and correcting) corruption. The odds of
disk corruption are admittedly very low, but violating users' expectations
of data safety, especially when they've gone out of their way to use a
filesystem which touts data safety, is bad.
[Test Case]
$ truncate -s 1G test.img
$ sudo zpool create test `pwd`/test.img
$ sudo zpool status test
$ sudo vi /etc/cron.
Modify /etc/cron.
(modifying the date range if it's not currently the 8th through the 14th
and the "-eq 0" check if it's not currently a Sunday).
$ grep zfs /var/log/cron.log
Verify in /var/log/cron.log that the job ran.
$ sudo zpool status test
Expected results:
scan: scrub repaired 0 in ... on <shortly after the cron job ran>
Actual results:
scan: none requested
Then, add the PATH line, update the time rules in the cron job, and repeat
the test. Now it will work.
- OR -
The best test case is to leave the cron job file untouched, install the
patched package, wait for the second Sunday of the month, and verify with
zpool status that a scrub ran. I did this, on Xenial, with the package I
built. The debdiff is in comment #11 and was accepted to Yakkety.
If someone can get this in -proposed before the 14th, I'll gladly install
the actual package from -proposed and make sure it runs correctly on the
14th.
[Regression Potential]
The patch only touches the cron.d file, which has only one cron job in it.
This cron job is completely broken (inoperative) at the moment, so the
regression potential is very low.
ORIGINAL, PRE-SRU, DESCRIPTION:
mdadm automatically checks MD arrays. ZFS should automatically scrub pools too. Scrubbing a pool allows ZFS to detect on-disk corruption and (when the pool has redundancy) correct it. Note that ZFS does not blindly assume the other copy is correct; it will only overwrite bad data with data that is known to be good (i.e. it passes the checksum).
I've attached a debdiff which accomplishes this. It builds and installs cleanly.
The meat of it is the scrub script I've been using on production systems, both servers and laptops, and recommending in my Ubuntu root-on-ZFS HOWTO, for years, which scrubs all *healthy* pools. If a pool is not healthy, scrubbing it is bad for two reasons: 1) It adds a lot of disk load which could theoretically lead to another failure. We should save that disk load for resilvering. 2) Performance is already less on a degraded pool and scrubbing can make that worse, even though scrubs are throttled. Arguably, I might be being too conservative here, but the marginal benefit of scrubbing a *degraded* pool is pretty minimal as pools should not be left degraded for very long.
The cron.d in this patch scrubs on the second Sunday of the month. mdadm scrubs on the first Sunday of the month. This way, if a system has both MD and ZFS pools, the load doesn't all happen at the same time. If the system doesn't have both types, it shouldn't really matter which week. If you'd rather make it the same week as MD, I see no problem with that.
Changed in zfs-linux (Ubuntu): | |
importance: | Undecided → Wishlist |
Changed in zfs-linux (Ubuntu): | |
assignee: | nobody → Colin Ian King (colin-king) |
description: | updated |
description: | updated |
summary: |
- ZFS pools should be automatically scrubbed + [FFe] ZFS pools should be automatically scrubbed |
description: | updated |
Changed in zfs-linux (Ubuntu): | |
status: | Fix Released → Confirmed |
summary: |
- [FFe] ZFS pools should be automatically scrubbed + ZFS pools should be automatically scrubbed |
Changed in zfs-linux (Ubuntu): | |
importance: | Wishlist → Medium |
status: | Confirmed → In Progress |
description: | updated |
Changed in zfs-linux (Ubuntu Xenial): | |
importance: | Undecided → Medium |
The attachment "zfs-linux. scrub.debdiff. 2" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.
[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]