php-directory-scanner: add nocheck and stage1 build profiles

[Nish Aravamudan]

In order to remove PHP5 from the archive, a set of build-dependency loops need to be bootstrapped. php-directory-scanner depends on phpunit and symfony packages, which need to be bootstrapped.

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "php-directory-scanner.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

[Steve Langasek (vorlon)]

+ifeq (,$(filter nocheck stage1, $(DEB_BUILD_OPTIONS) $(DEB_BUILD_PROFILES)))

I don't think this is correct. The filter command takes a single pattern, followed by a set of whitespace-separated values to match it against. I don't believe you can filter both nocheck and stage1 in a single command.

[Nish Aravamudan (nacc)]

Per https://www.gnu.org/software/make/manual/html_node/Text-Functions.html, it is allowed:

"$(filter pattern…,text)

    Returns all whitespace-separated words in text that do match any of the pattern words, removing any words that do not match. The patterns are written using ‘%’, just like the patterns used in the patsubst function above."

It did seem to work in my testing (that is specifying -Pnocheck or -Pstage1 dtrt.)

[Steve Langasek (vorlon)]

On Thu, Feb 11, 2016 at 04:25:10PM -0000, Nish Aravamudan wrote:
> Per https://www.gnu.org/software/make/manual/html_node/Text-
> Functions.html, it is allowed:

> "$(filter pattern…,text)

> Returns all whitespace-separated words in text that do match any of
> the pattern words, removing any words that do not match. The patterns
> are written using ‘%’, just like the patterns used in the patsubst
> function above."

> It did seem to work in my testing (that is specifying -Pnocheck or
> -Pstage1 dtrt.)

ah, TIL! thanks!

[Steve Langasek (vorlon)]

uploaded, with the minor change of running 'update-maintainer' to fix the maintainer field, and documenting this bug # in the changelog.

[Launchpad Janitor (janitor)]

This bug was fixed in the package php-directory-scanner - 1.3.1-2ubuntu1

---------------
php-directory-scanner (1.3.1-2ubuntu1) xenial; urgency=medium

  * add nocheck build profile.
  * add stage1 build profile.
  * LP: #1543399.

 -- Nishanth Aravamudan <email address hidden> Mon, 08 Feb 2016 17:58:22 -0800

[Nish Aravamudan (nacc)]

Do we need to also version these changes? That is, pkg-php-tools >= 1.32~?

[Steve Langasek (vorlon)]

On Fri, Feb 12, 2016 at 10:57:54PM -0000, Nish Aravamudan wrote:
> Do we need to also version these changes? That is, pkg-php-tools >=
> 1.32~?

No; the package will just build differently when building with old vs. new
pkg-php-tools, but that's ok, it just results in a no-change rebuild to the
package once the new pkg-php-tools is available. And no-change rebuilds are
a lot cheaper to batch.

Any packages that don't *mis*build with older pkg-php-tools are ok to upload
now with these changes to support stage1 profile.

[Nish Aravamudan (nacc)]

> No; the package will just build differently when building with old vs. new
> pkg-php-tools, but that's ok, it just results in a no-change rebuild to the
> package once the new pkg-php-tools is available. And no-change rebuilds are
> a lot cheaper to batch.

Will that automatically happen or should I document this as also needing
to be rebuilt?

> Any packages that don't *mis*build with older pkg-php-tools are ok to upload
> now with these changes to support stage1 profile.

Ah, I see! Hrm, then maybe my work today was not necessary and I
misunderstood. *sigh*, I'll think it over.

[Steve Langasek (vorlon)]

On Sat, Feb 13, 2016 at 12:45:33AM -0000, Nish Aravamudan wrote:
> > No; the package will just build differently when building with old vs. new
> > pkg-php-tools, but that's ok, it just results in a no-change rebuild to the
> > package once the new pkg-php-tools is available. And no-change rebuilds are
> > a lot cheaper to batch.

> Will that automatically happen or should I document this as also needing
> to be rebuilt?

Please document this as also requiring a rebuild.

The preference from my side is to, as much as possible, bootstrap with
pristine sources from the Ubuntu archive. So if packages can be changed to
support a stage1 build profile, and be uploaded to the archive now, I
believe it's better to do this and get this in the archive now; then
afterwards do stage1 bootstrap builds, and finally do no-change rebuilds to
the archive. This lets us separate the "bootstrap" process from the
"sourceful changes" process, and reduce the risk of misbuilds or
mis-uploads.