upgrade php-memcache for PHP7.0

Bug #1543349 reported by Nish Aravamudan
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
php-memcache (Ubuntu)
Fix Released
Wishlist
Unassigned

Bug Description

The current version of src:php-memcache produces php5-memcache. As we look to transition to PHP7.0, we need to update to the latest version.

URL: https://github.com/websupport-sk/pecl-memcache
License: PHP 3.0
Notes: This external version of php-memcache has not yet been packaged in Debian.

For the purposes of bootstrapping in a PPA, I modified the existing src:php-memcache directly to the version from the above URL, and made the following alterations:

d/c: s/php5/php/
d/c: s/PHP5/PHP/
d/php5* -> d/php*
d/r: s/php5/php/

Nish Aravamudan (nacc)
description: updated
affects: pkg-php-tools (Ubuntu) → php-memcache (Ubuntu)
Revision history for this message
Brian Murray (brian-murray) wrote :

*** This is an automated message ***

This bug is tagged needs-packaging which identifies it as a request for a new package in Ubuntu. As a part of the managing needs-packaging bug reports specification, https://wiki.ubuntu.com/QATeam/Specs/NeedsPackagingBugs, all needs-packaging bug reports have Wishlist importance. Subsequently, I'm setting this bug's status to Wishlist.

Changed in php-memcache (Ubuntu):
importance: Undecided → Wishlist
Mathew Hodson (mhodson)
tags: added: upgrade-software-version
removed: needs-packaging
summary: - [needs-packaging] php-memcache
+ upgrade php-memcache for PHP7.0
Revision history for this message
Steve Langasek (vorlon) wrote :

It looks like we already have the latest upstream release packaged (3.0.8) and we need to pull git HEAD here, is that correct?

Revision history for this message
Steve Langasek (vorlon) wrote :

Grabbed the php-memcache package from the ppa; feedback:
 - you have labelled this package as '3.0.9'. However there is no upstream release 3.0.9 that I can find. If it has been released, please point me to it. If not, we should not use this version number on upstream's behalf. (For my testing, I used 3.0.8+20151130.fdbd46b, which corresponds to the current git commit.)
 - the contents of the orig.tar.gz unpack into a memcache-3.0.8 subdirectory, which reinforces the belief that this is not a new upstream release; you then apply a diff from debian/patches that completely removes the contents of memcache-3.0.8 and replaces them with a memcache-3.0.9 directory. This is awkward. If we are going to bump the upstream version number at all then the orig.tar.gz should contain the actual sources for that version; if we're not going to bump it then debian/patches should apply in place, not replacing one subdirectory with another. (the latter implies not updating the version string i package.xml.)
- your description of the process to create the new source package is somewhat incomplete; there are references to php5 in the debian/php5* files that also need to be changed. That's fine, easily figured out and you've done this in your version of the package.
- the build dependencies listed for this package are all satisfied at present in xenial, but building with the modified source package against the xenial versions of the build-deps yields an empty package containing no .so. So it appears newer versions of php-pear and/or pkg-php-tools are required before this package can be built. It is preferable to express this as a versioned build-dependency, so that we avoid accidental misbuilds.

I'll attach the source package I've generated here. Please review it and let me know if I've made any mistakes.

Revision history for this message
Steve Langasek (vorlon) wrote :
Revision history for this message
Steve Langasek (vorlon) wrote :
Steve Langasek (vorlon)
Changed in php-memcache (Ubuntu):
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package php-memcache - 3.0.9~20151130.fdbd46b-0ubuntu1

---------------
php-memcache (3.0.9~20151130.fdbd46b-0ubuntu1) xenial; urgency=medium

  * New upstream git snapshot. LP: #1543349.
  * Update to build against php7, with versioned build-dependency against
    pkg-php-tools >= 1.32~ to avoid misbuild before php7 support has landed
    in those tools.

 -- Steve Langasek <email address hidden> Fri, 12 Feb 2016 21:25:13 -0800

Changed in php-memcache (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.