upgrade to pkg-php-tools 1.32

[Nish Aravamudan]

An updated pkg-php-tools is needed to bootstrap PHP7.0 dependencies throught the archive (i.e., the dh_phppear and dh_phpcomposer tools).

URL: http://anonscm.debian.org/cgit/pkg-php/pkg-php-tools.git/log/?h=master-7.0
License: LGPL
Notes: This should result in version 1.32 being packaged. It is not yet packaged for Debian (but I expect it will be at some point).

[Brian Murray (brian-murray)]

*** This is an automated message ***

This bug is tagged needs-packaging which identifies it as a request for a new package in Ubuntu. As a part of the managing needs-packaging bug reports specification, https://wiki.ubuntu.com/QATeam/Specs/NeedsPackagingBugs, all needs-packaging bug reports have Wishlist importance. Subsequently, I'm setting this bug's status to Wishlist.

[Steve Langasek (vorlon)]

Trying to build this from the Debian git repository fails in the test suite as follows:

   dh_auto_test
 make -j1 test
make[1]: Entering directory '/tmp/build-area/pkg-php-tools-1.32~exp1'
sh testsuite/runtests.sh
[...]
Running test: 201_Debian_Debhelper_Buildsystem_phppear.sh
 cp package.xml ./MyProject_Packages-1.2.1/package.xml
 sed -i -e s/md5sum=\"\[^\"\]\*\"// -e s/sha1sum=\"\[^\"\]\*\"// ./MyProject_Packages-1.2.1/package.xml
 /usr/bin/pear -c debian/pearrc -d download_dir=/tmp -d include_path=/usr/share/php -d php_bin=/usr/bin/php -d bin_dir=/usr/bin -d php_dir=/usr/share/php -d data_dir=/usr/share/php/data -d doc_dir=/usr/share/doc/php-foo -d test_dir=/usr/share/php/tests install --offline --nodeps -P /tmp/6SOImKhlpj ./MyProject_Packages-1.2.1/package.xml
PHP Parse error: syntax error, unexpected 'new' (T_NEW) in /usr/share/php/PEAR/Frontend.php on line 91
201_Debian_Debhelper_Buildsystem_phppear.pl: /usr/bin/pear -c debian/pearrc -d download_dir=/tmp -d include_path=/usr/share/php -d php_bin=/usr/bin/php -d bin_dir=/usr/bin -d php_dir=/usr/share/php -d data_dir=/usr/share/php/data -d doc_dir=/usr/share/doc/php-foo -d test_dir=/usr/share/php/tests install --offline --nodeps -P /tmp/6SOImKhlpj ./MyProject_Packages-1.2.1/package.xml returned exit code 255
UNKNOWN

Is this package missing a versioned dependency on php-pear (bug #1543324)? Should we upload and trust that it will be fixed once php-pear is available?

[Nish Aravamudan (nacc)]

Argh, you're right, Steve! I'm sorry, when I built the pkg-php-tools in the side PPA, it used the php-pear from the referenced bug as built in that PPA (https://launchpadlibrarian.net/234638050/buildlog_ubuntu-xenial-amd64.pkg-php-tools_1.32~exp1~ppa_BUILDING.txt.gz). So yeah, it probably needs a versioned dependency to require specifically that level of php-pear. I will note that with that version installed, it does pass the tests in my testing. Do you want me to post an updated debdiff?

[Steve Langasek (vorlon)]

On Thu, Feb 11, 2016 at 11:17:37PM -0000, Nish Aravamudan wrote:
> Argh, you're right, Steve! I'm sorry, when I built the pkg-php-tools in
> the side PPA, it used the php-pear from the referenced bug as built in
> that PPA (https://launchpadlibrarian.net/234638050/buildlog_ubuntu-
> xenial-amd64.pkg-php-tools_1.32~exp1~ppa_BUILDING.txt.gz). So yeah, it
> probably needs a versioned dependency to require specifically that level
> of php-pear. I will note that with that version installed, it does pass
> the tests in my testing. Do you want me to post an updated debdiff?

No need. This package has been uploaded to xenial-proposed as-is, and will
block there until buildable.

[Steve Langasek (vorlon)]

This package is now buildable, but is blocked in xenial-proposed because its autopkgtests fail, both with or without the new php-pear:

  http://autopkgtest.ubuntu.com/packages/p/pkg-php-tools/xenial/amd64/

(reproducible for all arches)

sample failure is: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/amd64/p/pkg-php-tools/20160219_055642@/log.gz

This shows incompatibilities both with php-json and with php-pear.

Nish, can you please follow up on this?

[Nish Aravamudan (nacc)]

Please merge with Debian bb557427 ("Prepare pkg-php-tools (1.32)")_ in order to pass the autopkgtests:

pkg-php-tools (1.32ubuntu1) xenial; urgency=medium

  * tests/PhpcomposerSourceTest.php: update php-json error message
    (Debian #814858).
  * LP: #1543324.

 -- Nishanth Aravamudan <email address hidden> Tue, 23 Feb 2016 14:31:06 -0800

I have sent the same fix to Debian in the above bug, and hopefully it also gets picked up in time for 1.32, in which case we can sync.

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "pkg-php-tools.1.32ubuntu1.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

[Steve Langasek (vorlon)]

Why have you added the build-dependency / test dependency on php-xml? I don't see any mention of this in the test logs. The JSON error string fix appears to be sufficient to resolve the build failures, from what I see of the log.

[Steve Langasek (vorlon)]

OK, I've checked and it seems the package now FTBFS without the build-dependency on php-xml. So +1 for that.

I cannot confirm that php-xml is also needed as a test dependency, but it also doesn't do any major harm and can be cleaned up with the Debian maintainers later.

[Launchpad Janitor (janitor)]

This bug was fixed in the package pkg-php-tools - 1.32ubuntu1

---------------
pkg-php-tools (1.32ubuntu1) xenial; urgency=medium

  * tests/PhpcomposerSourceTest.php: update php-json error message
    (Debian Bug #814858).
  * Add php-xml as Build-dep and test dep.
  * LP: #1543334.

 -- Nishanth Aravamudan <email address hidden> Tue, 23 Feb 2016 14:31:06 -0800