installer/netcfg gives misleading error message when parsing line with trailing blanks

[bugproxy]

== Comment: #0 - Thorsten Diehl - 2016-02-04 08:52:12 ==
During the very early phase of the installer (build 416) within the z/VM console, when I enter e.g. the IP address and append by accident one ore more trailing blanks, the IP address is treated as malformed.
Recommendation: leading and trailing blanks should be ignored.

Configure a network using static addressing
-------------------------------------------

The IP address is unique to your computer and may be:

 * four numbers separated by periods (IPv4);
 * blocks of hexadecimal characters separated by colons (IPv6).

You can also optionally append a CIDR netmask (such as "/24").

If you don't know what to use here, consult your network administrator.
IP address:
Prompt: '?' for help> 9.152.162.103
9.152.162.103

!! ERROR: Malformed IP address

The IP address you provided is malformed. It should be in the form x.x.x.x
where each 'x' is no larger than 255 (an IPv4 address), or a sequence of blocks

of hexadecimal digits separated by colons (an IPv6 address). Please try again.
?Press enter to continue?

[bugproxy (bugproxy)]

------- Comment From <email address hidden> 2016-03-18 12:49 EDT-------
Package: netcfg
Version: 1.137
Severity: normal
Tags: d-i

Dear maintainer(s),

when specifying IP addresses with leading or trailing blanks, netcfg does not
correctly identify the IP address and fails. For example,

Configure a network using static addressing
-------------------------------------------

The IP address is unique to your computer and may be:

* four numbers separated by periods (IPv4);
* blocks of hexadecimal characters separated by colons (IPv6).

You can also optionally append a CIDR netmask (such as "/24").

If you don't know what to use here, consult your network administrator.
IP address:
Prompt: '?' for help> 9.152.162.103
9.152.162.103

!! ERROR: Malformed IP address

The IP address you provided is malformed. It should be in the form x.x.x.x
where each 'x' is no larger than 255 (an IPv4 address), or a sequence of blocks

of hexadecimal digits separated by colons (an IPv6 address). Please try again.
Press enter to continue

This can easily happen, especially, when entering IP addresses within
command line console, such as the z/VM console on z Systems (s390x).

The expected behavior is that leading and trailing blanks should be ignored.
Note that the root cause of the error condition above is triggered by a
failing inet_pton() call which does not expect blanks for an IP address
string.

To correct this behavior, I have attached two patches for discussion:

The first patch removes trailing blanks for the case above. Note that there
is already an rtrim() function that has been reused. Also an additional
function, strtrim(), is introduced to remove any leading blanks.
The "make test" has been enhanced to verify this behavior.

The second patch removes leading and trailing blanks on IP addresses entered
for other network configurations, for example, point-to-point.

The patch are attached on the related Debian bug report at:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=818611

[Dimitri John Ledkov (xnox)]

In unapproved queue https://launchpad.net/ubuntu/xenial/+queue?queue_state=1&queue_text=

[Launchpad Janitor (janitor)]

This bug was fixed in the package netcfg - 1.135ubuntu2

---------------
netcfg (1.135ubuntu2) xenial; urgency=medium

  Cherrypick commits from debian netcfg master.

  [ Hendrik Brueckner ]
  * common/ipaddr: remove leading and trailing whitespaces
  * static: trim user-specified values for IP and other addresses
  * Closes: #818611, LP: #1541955

  [ Dimitri John Ledkov ]
  * Makefile: link with -lm to resolve undefined log and other functions

 -- Dimitri John Ledkov <email address hidden> Thu, 31 Mar 2016 13:55:14 +0100

[Dimitri John Ledkov (xnox)]

I have rebuild d-i with updated netcfg and it appears that I am still seeing "Malformed IP address" notices from netcfg. This is with z/VM installation. I guess i should rebuild a debug version which logs actual characters that are communicated across. This is with apl charset.

[Dimitri John Ledkov (xnox)]

actually, this is all good - booted out of date installer.

[Launchpad Janitor (janitor)]

This bug was fixed in the package debian-installer - 20101020ubuntu445

---------------
debian-installer (20101020ubuntu445) xenial; urgency=medium

  * Add necessory files to enable FTP Load / IPL on s390x, ported from
    debian-cd.
  * Drop s390-dasd, is now pulled in via hw-detect /
    harddrive-detection-dasd.
  * Rebuild with ipv6 capable network-console. LP: #1552368

 -- Dimitri John Ledkov <email address hidden> Tue, 05 Apr 2016 09:51:35 +0100

[bugproxy (bugproxy)]

------- Comment From <email address hidden> 2016-04-07 04:33 EDT-------
sucessfully verified with installer version 445. Closed.