Bug #1540511 “Touchpad not working (4.3 -> 4.4 regression)” : Bugs : linux package : Ubuntu

Revision history for this message

David Henningsson (diwic) wrote on 2016-02-01:

#1

AlsaInfo.txt Edit (33.4 KiB, text/plain; charset="utf-8")
CRDA.txt Edit (392 bytes, text/plain; charset="utf-8")
CurrentDmesg.txt Edit (65.9 KiB, text/plain; charset="utf-8")
Dependencies.txt Edit (2.1 KiB, text/plain; charset="utf-8")
IwConfig.txt Edit (519 bytes, text/plain; charset="utf-8")
JournalErrors.txt Edit (23.8 KiB, text/plain; charset="utf-8")
Lspci.txt Edit (7.4 KiB, text/plain; charset="utf-8")
Lsusb.txt Edit (428 bytes, text/plain; charset="utf-8")
ProcCpuinfo.txt Edit (4.4 KiB, text/plain; charset="utf-8")
ProcEnviron.txt Edit (325 bytes, text/plain; charset="utf-8")
ProcInterrupts.txt Edit (3.1 KiB, text/plain; charset="utf-8")
ProcModules.txt Edit (8.8 KiB, text/plain; charset="utf-8")
PulseList.txt Edit (19.7 KiB, text/plain; charset="utf-8")
RfKill.txt Edit (112 bytes, text/plain; charset="utf-8")
UdevDb.txt Edit (176.3 KiB, text/plain; charset="utf-8")
WifiSyslog.txt Edit (106.2 KiB, text/plain; charset="utf-8")

description:

updated

Revision history for this message

Brad Figg (brad-figg) wrote on 2016-02-01: Status changed to Confirmed

#2

This change was made by a bot.

Changed in linux (Ubuntu):
status:	New → Confirmed

Revision history for this message

Joseph Salisbury (jsalisbury) wrote on 2016-02-02:

#3

Would it be possible for you to test the latest upstream kernel? Refer to https://wiki.ubuntu.com/KernelMainlineBuilds . Please test the latest v4.5 kernel[0].

If this bug is fixed in the mainline kernel, please add the following tag 'kernel-fixed-upstream'.

If the mainline kernel does not fix this bug, please add the tag: 'kernel-bug-exists-upstream'.

Once testing of the upstream kernel is complete, please mark this bug as "Confirmed".

Thanks in advance.

[0] http://kernel.ubuntu.com/~kernel-ppa/mainline/v4.5-rc2-wily/

Changed in linux (Ubuntu):
importance:	Undecided → Medium
tags:	added: kernel-da-key

penalvch (penalvch) on 2016-02-11

tags:	added: regression-release
Changed in linux (Ubuntu):
status:	Confirmed → Incomplete

Revision history for this message

David Henningsson (diwic) wrote on 2016-02-11:

#4

Tested kernels so far:

4.3.0-7 ubuntu - good (touchpad working)
4.5.0-040500rc3 - good (touchpad working)
4.4.0-4 ubuntu - bad (touchpad not working)
4.4.1-040401 - bad (touchpad not working)
4.5.0-040500rc1 - good (touchpad working)

Looks like a temporary regression in 4.4 - maybe we can bisect between 4.4 and 4.5rc1 to see if it's something we can backport?

tags:	added: kernel-fixed-upstream
Changed in linux (Ubuntu):
status:	Incomplete → Confirmed

Revision history for this message

David Henningsson (diwic) wrote on 2016-02-11:

#5

I'm working on it, here's the result so far:

$ git bisect log
git bisect start
# new: [92e963f50fc74041b5e9e744c330dca48e04f08d] Linux 4.5-rc1
git bisect new 92e963f50fc74041b5e9e744c330dca48e04f08d
# old: [afd2ff9b7e1b367172f18ba7f693dfb62bdcb2dc] Linux 4.4
git bisect old afd2ff9b7e1b367172f18ba7f693dfb62bdcb2dc
# old: [1289ace5b4f70f1e68ce785735b82c7e483de863] Merge tag 'scsi-misc' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi
git bisect old 1289ace5b4f70f1e68ce785735b82c7e483de863
# new: [984065055e6e39f8dd812529e11922374bd39352] Merge branch 'drm-next' of git://people.freedesktop.org/~airlied/linux
git bisect new 984065055e6e39f8dd812529e11922374bd39352

Revision history for this message

penalvch (penalvch) wrote on 2016-02-11:

#6

David Henningsson, when the reverse bisect commit fix is identified, please mark this Confirmed.

tags:	added: needs-reverse-bisect
Changed in linux (Ubuntu):
status:	Confirmed → Incomplete

Revision history for this message

David Henningsson (diwic) wrote on 2016-02-11:

#7

A few more commits...

# new: [92e963f50fc74041b5e9e744c330dca48e04f08d] Linux 4.5-rc1
git bisect new 92e963f50fc74041b5e9e744c330dca48e04f08d
# old: [afd2ff9b7e1b367172f18ba7f693dfb62bdcb2dc] Linux 4.4
git bisect old afd2ff9b7e1b367172f18ba7f693dfb62bdcb2dc
# old: [1289ace5b4f70f1e68ce785735b82c7e483de863] Merge tag 'scsi-misc' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi
git bisect old 1289ace5b4f70f1e68ce785735b82c7e483de863
# new: [984065055e6e39f8dd812529e11922374bd39352] Merge branch 'drm-next' of git://people.freedesktop.org/~airlied/linux
git bisect new 984065055e6e39f8dd812529e11922374bd39352
# new: [a016af2e70bfca23f2f5de7d8708157b86ea374d] Merge tag 'sound-4.5-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound
git bisect new a016af2e70bfca23f2f5de7d8708157b86ea374d
# new: [d45187aaf0e256d23da2f7694a7826524499aa31] Merge branch 'dmi-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jdelvare/staging
git bisect new d45187aaf0e256d23da2f7694a7826524499aa31
# new: [c2848f2eef4dd08b0fd2a8eba1694fd8e77ddb67] Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid
git bisect new c2848f2eef4dd08b0fd2a8eba1694fd8e77ddb67
# old: [5339f9d4c2ceccab00b28d65bd5c2b2cd6a3de05] Merge tag 'devicetree-for-4.5' of git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux
git bisect old 5339f9d4c2ceccab00b28d65bd5c2b2cd6a3de05

Revision history for this message

David Henningsson (diwic) wrote on 2016-02-12:

#8

it bisect start
# new: [92e963f50fc74041b5e9e744c330dca48e04f08d] Linux 4.5-rc1
git bisect new 92e963f50fc74041b5e9e744c330dca48e04f08d
# old: [afd2ff9b7e1b367172f18ba7f693dfb62bdcb2dc] Linux 4.4
git bisect old afd2ff9b7e1b367172f18ba7f693dfb62bdcb2dc
# old: [1289ace5b4f70f1e68ce785735b82c7e483de863] Merge tag 'scsi-misc' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi
git bisect old 1289ace5b4f70f1e68ce785735b82c7e483de863
# new: [984065055e6e39f8dd812529e11922374bd39352] Merge branch 'drm-next' of git://people.freedesktop.org/~airlied/linux
git bisect new 984065055e6e39f8dd812529e11922374bd39352
# new: [a016af2e70bfca23f2f5de7d8708157b86ea374d] Merge tag 'sound-4.5-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound
git bisect new a016af2e70bfca23f2f5de7d8708157b86ea374d
# new: [d45187aaf0e256d23da2f7694a7826524499aa31] Merge branch 'dmi-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jdelvare/staging
git bisect new d45187aaf0e256d23da2f7694a7826524499aa31
# new: [c2848f2eef4dd08b0fd2a8eba1694fd8e77ddb67] Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid
git bisect new c2848f2eef4dd08b0fd2a8eba1694fd8e77ddb67
# old: [5339f9d4c2ceccab00b28d65bd5c2b2cd6a3de05] Merge tag 'devicetree-for-4.5' of git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux
git bisect old 5339f9d4c2ceccab00b28d65bd5c2b2cd6a3de05
# old: [63f729cb4aa9a224cfd6bb35eab6b4556c29115d] Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
git bisect old 63f729cb4aa9a224cfd6bb35eab6b4556c29115d
# old: [210c7c1750fdf769647d1d526c9ea34c412c9eee] NFS: Use wait_on_atomic_t() for unlock after readahead
git bisect old 210c7c1750fdf769647d1d526c9ea34c412c9eee

Looked through remaining commits, I'm going to try this one next, looks promising:

commit 73e7d63efb4d774883a338997943bfa59e127085
Author: Benjamin Tissoires <email address hidden>
Date: Tue Dec 1 12:41:38 2015 +0100

HID: multitouch: fix input mode switching on some Elan panels

it bisect start
# new: [92e963f50fc74041b5e9e744c330dca48e04f08d] Linux 4.5-rc1
git bisect new 92e963f50fc74041b5e9e744c330dca48e04f08d
# old: [afd2ff9b7e1b367172f18ba7f693dfb62bdcb2dc] Linux 4.4
git bisect old afd2ff9b7e1b367172f18ba7f693dfb62bdcb2dc
# old: [1289ace5b4f70f1e68ce785735b82c7e483de863] Merge tag 'scsi-misc' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi
git bisect old 1289ace5b4f70f1e68ce785735b82c7e483de863
# new: [984065055e6e39f8dd812529e11922374bd39352] Merge branch 'drm-next' of git://people.freedesktop.org/~airlied/linux
git bisect new 984065055e6e39f8dd812529e11922374bd39352
# new: [a016af2e70bfca23f2f5de7d8708157b86ea374d] Merge tag 'sound-4.5-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound
git bisect new a016af2e70bfca23f2f5de7d8708157b86ea374d
# new: [d45187aaf0e256d23da2f7694a7826524499aa31] Merge branch 'dmi-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jdelvare/staging
git bisect new d45187aaf0e256d23da2f7694a7826524499aa31
# new: [c2848f2eef4dd08b0fd2a8eba1694fd8e77ddb67] Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid
git bisect new c2848f2eef4dd08b0fd2a8eba1694fd8e77ddb67
# old: [5339f9d4c2ceccab00b28d65bd5c2b2cd6a3de05] Merge tag 'devicetree-for-4.5' of git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux
git bisect old 5339f9d4c2ceccab00b28d65bd5c2b2cd6a3de05
# old: [63f729cb4aa9a224cfd6bb35eab6b4556c29115d] Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
git bisect old 63f729cb4aa9a224cfd6bb35eab6b4556c29115d
# old: [210c7c1750fdf769647d1d526c9ea34c412c9eee] NFS: Use wait_on_atomic_t() for unlock after readahead
git bisect old 210c7c1750fdf769647d1d526c9ea34c412c9eee

Looked through remaining commits, I'm going to try this one next, looks promising:

commit 73e7d63efb4d774883a338997943bfa59e127085
Author: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Date:   Tue Dec 1 12:41:38 2015 +0100

HID: multitouch: fix input mode switching on some Elan panels

Revision history for this message

David Henningsson (diwic) wrote on 2016-02-12:

#9

Ok, I've now built and tested a kernel with 4.4 + the below commit and can confirm that this commit fixes the touchpad issue for me.

commit 8a7fa6187191f005d4b6d29913de6e128cc778e2
Author: Benjamin Tissoires <email address hidden>
Date: Tue Dec 1 12:41:38 2015 +0100

HID: multitouch: fix input mode switching on some Elan panels

Revision history for this message

David Henningsson (diwic) wrote on 2016-02-12:

#10

https://bugzilla.kernel.org/show_bug.cgi?id=108481

Changed in linux (Ubuntu):
status:	Incomplete → Confirmed

Revision history for this message

Joseph Salisbury (jsalisbury) wrote on 2016-02-12:

#11

That commit was added in 4.5-rc1 and it was not cc'd to stable. We should request this commit in Xenial on the kernel team mailing list. Do you want to do that David, or do you want me to?

penalvch (penalvch) on 2016-02-12

tags:

added: cherry-pick reverse-bisect-done
removed: needs-reverse-bisect

Revision history for this message

David Henningsson (diwic) wrote on 2016-02-19: [PATCH] [xenial] (upstream) HID: multitouch: fix input mode switching on some Elan panels

#12

Download full text (4.5 KiB)

From: Benjamin Tissoires <email address hidden>

as reported by https://bugzilla.kernel.org/show_bug.cgi?id=108481

This bug reports mentions 6d4f5440 ("HID: multitouch: Fetch feature
reports on demand for Win8 devices") as the origin of the problem but this
commit actually masked 2 firmware bugs that are annihilating each other:

The report descriptor declares two features in reports 3 and 5:

0x05, 0x0d, // Usage Page (Digitizers) 318
0x09, 0x0e, // Usage (Device Configuration) 320
0xa1, 0x01, // Collection (Application) 322
0x85, 0x03, // Report ID (3) 324
0x09, 0x22, // Usage (Finger) 326
0xa1, 0x00, // Collection (Physical) 328
0x09, 0x52, // Usage (Inputmode) 330
0x15, 0x00, // Logical Minimum (0) 332
0x25, 0x0a, // Logical Maximum (10) 334
0x75, 0x08, // Report Size (8) 336
0x95, 0x02, // Report Count (2) 338
0xb1, 0x02, // Feature (Data,Var,Abs) 340
0xc0, // End Collection 342
0x09, 0x22, // Usage (Finger) 343
0xa1, 0x00, // Collection (Physical) 345
0x85, 0x05, // Report ID (5) 347
0x09, 0x57, // Usage (Surface Switch) 349
0x09, 0x58, // Usage (Button Switch) 351
0x15, 0x00, // Logical Minimum (0) 353
0x75, 0x01, // Report Size (1) 355
0x95, 0x02, // Report Count (2) 357
0x25, 0x03, // Logical Maximum (3) 359
0xb1, 0x02, // Feature (Data,Var,Abs) 361
0x95, 0x0e, // Report Count (14) 363
0xb1, 0x03, // Feature (Cnst,Var,Abs) 365
0xc0, // End Collection 367

The report ID 3 presents 2 input mode features, while only the first one
is handled by the device. Given that we did not checked if one was
previously assigned, we were dealing with the ignored featured and we
should never have been able to switch this panel into the multitouch mode.

However, the firmware presents an other bugs which allowed 6d4f5440
to counteract the faulty report descriptor. When we request the values
of the feature 5, the firmware answers "03 03 00". The fields are correct
but the report id is wrong. Before 6d4f5440, we retrieved all the features
and injected them in the system. So when we called report 5, we injected
in the system the report 3 with the values "03 00".
Setting the second input mode to 03 in this report changed it to "03 03"
and the touchpad switched to the mt mode. We could have set anything
in the second field because...

From: Benjamin Tissoires <benjamin.tissoires@redhat.com>

as reported by https://bugzilla.kernel.org/show_bug.cgi?id=108481

This bug reports mentions 6d4f5440 ("HID: multitouch: Fetch feature
reports on demand for Win8 devices") as the origin of the problem but this
commit actually masked 2 firmware bugs that are annihilating each other:

The report descriptor declares two features in reports 3 and 5:

0x05, 0x0d,                    // Usage Page (Digitizers)             318
0x09, 0x0e,                    // Usage (Device Configuration)        320
0xa1, 0x01,                    // Collection (Application)            322
0x85, 0x03,                    //  Report ID (3)                      324
0x09, 0x22,                    //  Usage (Finger)                     326
0xa1, 0x00,                    //  Collection (Physical)              328
0x09, 0x52,                    //   Usage (Inputmode)                 330
0x15, 0x00,                    //   Logical Minimum (0)               332
0x25, 0x0a,                    //   Logical Maximum (10)              334
0x75, 0x08,                    //   Report Size (8)                   336
0x95, 0x02,                    //   Report Count (2)                  338
0xb1, 0x02,                    //   Feature (Data,Var,Abs)            340
0xc0,                          //  End Collection                     342
0x09, 0x22,                    //  Usage (Finger)                     343
0xa1, 0x00,                    //  Collection (Physical)              345
0x85, 0x05,                    //   Report ID (5)                     347
0x09, 0x57,                    //   Usage (Surface Switch)            349
0x09, 0x58,                    //   Usage (Button Switch)             351
0x15, 0x00,                    //   Logical Minimum (0)               353
0x75, 0x01,                    //   Report Size (1)                   355
0x95, 0x02,                    //   Report Count (2)                  357
0x25, 0x03,                    //   Logical Maximum (3)               359
0xb1, 0x02,                    //   Feature (Data,Var,Abs)            361
0x95, 0x0e,                    //   Report Count (14)                 363
0xb1, 0x03,                    //   Feature (Cnst,Var,Abs)            365
0xc0,                          //  End Collection                     367

The report ID 3 presents 2 input mode features, while only the first one
is handled by the device. Given that we did not checked if one was
previously assigned, we were dealing with the ignored featured and we
should never have been able to switch this panel into the multitouch mode.

However, the firmware presents an other bugs which allowed 6d4f5440
to counteract the faulty report descriptor. When we request the values
of the feature 5, the firmware answers "03 03 00". The fields are correct
but the report id is wrong. Before 6d4f5440, we retrieved all the features
and injected them in the system. So when we called report 5, we injected
in the system the report 3 with the values "03 00".
Setting the second input mode to 03 in this report changed it to "03 03"
and the touchpad switched to the mt mode. We could have set anything
in the second field because the actual value (the first 03 in this report)
was given by the query of report ID 5.

To sum up: 2 bugs in the firmware were hiding that we were accessing the
wrong feature.

Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>

BugLink: https://bugs.launchpad.net/bugs/1540511
(cherry picked from commit 73e7d63efb4d774883a338997943bfa59e127085)
Signed-off-by: David Henningsson <david.henningsson@canonical.com>
---
 drivers/hid/hid-multitouch.c | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
index 351ddd2..4ee7716 100644
--- a/drivers/hid/hid-multitouch.c
+++ b/drivers/hid/hid-multitouch.c
@@ -357,8 +357,19 @@ static void mt_feature_mapping(struct hid_device *hdev,
 			break;
 		}
 
-		td->inputmode = field->report->id;
-		td->inputmode_index = usage->usage_index;
+		if (td->inputmode < 0) {
+			td->inputmode = field->report->id;
+			td->inputmode_index = usage->usage_index;
+		} else {
+			/*
+			 * Some elan panels wrongly declare 2 input mode
+			 * features, and silently ignore when we set the
+			 * value in the second field. Skip the second feature
+			 * and hope for the best.
+			 */
+			dev_info(&hdev->dev,
+				 "Ignoring the extra HID_DG_INPUTMODE\n");
+		}
 
 		break;
 	case HID_DG_CONTACTMAX:
-- 
2.7.0

Revision history for this message

Tim Gardner (timg-tpi) wrote on 2016-02-19:

#13

Fix released in linux stable v4.4.2

Changed in linux (Ubuntu Xenial):
status:	Confirmed → Fix Released

Ubuntu
linux package

Touchpad not working (4.3 -> 4.4 regression)

Bug Description

Other bug subscribers

Bug attachments

Remote bug watches

Affects		Status	Importance	Assigned to	Milestone
	linux (Ubuntu)	Fix Released	Medium	Unassigned
	Xenial	Fix Released	Medium	Unassigned

Ubuntulinux package

Touchpad not working (4.3 -> 4.4 regression)

Bug Description

Other bug subscribers

Bug attachments

Remote bug watches

Ubuntu
linux package