install/ziomon: include FCP performance monitoring utilities in s390-tools

[bugproxy]

== Comment: #0 - Thorsten Diehl <email address hidden> - 2016-02-01 10:09:47 ==
Please include zfcp performance monitoring tools into s390-tools. A patch for debian has already been submitted and can be found under https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=812588

[Dimitri John Ledkov (xnox)]

Hello,

Would it be acceptable to ship ziomon in universe, instead of in main (and thus installed by default)?

The reason behind this is the dependency chain.

The proposed patch adds a Depends on "blktrace", which is in universe, and in turn depends on libtheora-bin & libav-tools (both in universe).

libav-tools come from a highly vulnerable package, which Ubuntu Security team deems as unsupportable.

I shall look into unwinding / reducing these dependencies, to have a possibility of including ziomon in main without the feature to generate H.264 videos.

Regards,

Dimitri.

[bugproxy (bugproxy)]

------- Comment From <email address hidden> 2016-02-02 11:07 EDT-------
Hi Dmitri,

(In reply to comment #5)
> Would it be acceptable to ship ziomon in universe, instead of in main (and
> thus installed by default)?

ziomon does not need to be installed by default. It makes sense for SCSI-only and mixed SCSI/DASD installations. The documentation should be updated so that administrators, performance users know to install it when required.

I presume you pursue the ziomon subpackage approach.

>
> The reason behind this is the dependency chain.
>
> The proposed patch adds a Depends on "blktrace", which is in universe, and
> in turn depends on libtheora-bin & libav-tools (both in universe).

On my Debian, it is strictly not a depends, rather than recommends:

Package: blktrace
State: not installed
Version: 1.1.0-2
Priority: extra
Section: utils
Maintainer: Bas Zoetekouw <email address hidden>
Architecture: s390x
Uncompressed Size: 1075 k
Depends: libaio1 (>= 0.3.93), libc6 (>= 2.15), python, lsb-base
Recommends: libtheora-bin, libav-tools, librsvg2-bin
Suggests: gnuplot-x11

>
> libav-tools come from a highly vulnerable package, which Ubuntu Security
> team deems as unsupportable.
>
> I shall look into unwinding / reducing these dependencies, to have a
> possibility of including ziomon in main without the feature to generate
> H.264 videos.

I think that such low-level tools like blktrace should not install video-related packages. So if you have some time it would be great to rethink whether these dependencies/recommends are really necessary and makes sense?

[Dimitri John Ledkov (xnox)]

I'll include the tools, but drop all the added dependencies to suggests. As really they are only needed in the ziomon case.

Maybe it's time to split s390-tools into essential and arbitrary things. Because e.g. s390-tools is installed by default across all things: server, cloud, virtual machine, lxc/lxd/docker container, minimal chroots. And a lot of these things don't make much sense everywhere.

Splitting/moving packages is not a problem, as it is still discoverable with rich metadata that we provide. E.g. both through apt, and the helpful command not found integration:

e.g.

$ hatop
The program 'hatop' is currently not installed. You can install it by typing:
sudo apt install hatop

[bugproxy (bugproxy)]

------- Comment on attachment From <email address hidden> 2016-02-09 08:00 EDT-------

Hello Dimitri,

I am the maintainer of s390-tools from IBM. Perhaps the attached document can help you to structure the s390-tools package for Debian/Ubuntu.

Due to historic reasons the s390-tools packaging is very different between SUSE (monolithic approach) and Red Hat (sub-package approach). Both have their pros and cons.

If you are interested, we can help you to find the "best" packaging solution ;-)

Michael Holzheu <email address hidden>

[Launchpad Janitor (janitor)]

This bug was fixed in the package s390-tools - 1.33.0-0ubuntu2

---------------
s390-tools (1.33.0-0ubuntu2) xenial; urgency=medium

  [ Hendrik Brueckner ]
  * Add zfcp monitoring and reporting tools (ziomon) (Closes: #812588)
    LP: #1540425.

  [ Dimitri John Ledkov ]
  * Drop dependencies/recommendencies for ziomon to Suggests, to avoid
    pulling those large packages, on all installation types (including
    virtual machines, cloud images, lxc/lxd/docker containers)

  * Possibly it is time to split s390-tools into essential, and optional
    binary packages with correct dependencies.

 -- Dimitri John Ledkov <email address hidden> Tue, 09 Feb 2016 11:38:46 +0000

[bugproxy (bugproxy)]

------- Comment From <email address hidden> 2016-02-12 13:03 EDT-------
Packages available in s390-tools (1.33.0-0ubuntu2), sniff testing of ziomon returned plausible data. Closed.