Implement keyboard navigation in narrow views
Bug #1539221 reported by
Olivier Tilloy
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Canonical System Image |
Fix Released
|
Medium
|
Bill Filler | ||
| webbrowser-app (Ubuntu) |
Fix Released
|
High
|
Olivier Tilloy | ||
Bug Description
Keyboard navigation is generally implemented in wide views (history view, bookmarks view, new tab view), but not in their narrow counterparts. With convergence becoming a serious focus, there is no reason not to support e.g. a keyboard attached to a phone.
Related branches
lp:~osomon/webbrowser-app/keyboard-nav-narrow
- PS Jenkins bot: Needs Fixing (continuous-integration)
- Ubuntu Phablet Team: Pending requested
-
Diff: 2400 lines (+1100/-505)25 files modifiedsrc/app/webbrowser/BookmarksFoldersView.qml (+212/-125)
src/app/webbrowser/BookmarksFoldersViewWide.qml (+1/-6)
src/app/webbrowser/BookmarksView.qml (+2/-3)
src/app/webbrowser/Browser.qml (+33/-29)
src/app/webbrowser/BrowserPageHeader.qml (+2/-1)
src/app/webbrowser/DownloadDelegate.qml (+1/-0)
src/app/webbrowser/DownloadsPage.qml (+21/-4)
src/app/webbrowser/ExpandedHistoryView.qml (+16/-6)
src/app/webbrowser/HistoryView.qml (+13/-3)
src/app/webbrowser/ListViewHighlight.qml (+11/-2)
src/app/webbrowser/NewTabView.qml (+245/-130)
src/app/webbrowser/NewTabViewWide.qml (+1/-11)
src/app/webbrowser/ToolbarAction.qml (+1/-0)
src/app/webbrowser/UrlDelegate.qml (+16/-5)
src/app/webbrowser/UrlPreviewDelegate.qml (+5/-1)
src/app/webbrowser/UrlPreviewGrid.qml (+23/-16)
src/app/webbrowser/UrlsList.qml (+0/-52)
tests/autopilot/webbrowser_app/emulators/browser.py (+9/-17)
tests/autopilot/webbrowser_app/tests/test_new_tab_view.py (+13/-18)
tests/unittests/qml/CMakeLists.txt (+2/-0)
tests/unittests/qml/tst_BookmarksView.qml (+82/-3)
tests/unittests/qml/tst_HistoryView.qml (+50/-4)
tests/unittests/qml/tst_NewTabView.qml (+292/-0)
tests/unittests/qml/tst_NewTabViewWide.qml (+1/-10)
tests/unittests/qml/tst_QmlTests.cpp (+48/-59)
| Changed in canonical-devices-system-image: | |
| assignee: | nobody → Bill Filler (bfiller) |
| milestone: | none → ww08-2016 |
| importance: | Undecided → Medium |
| Changed in webbrowser-app (Ubuntu): | |
| status: | Triaged → In Progress |
| Changed in canonical-devices-system-image: | |
| status: | New → In Progress |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #1 |
| Changed in webbrowser-app (Ubuntu): | |
| status: | In Progress → Fix Released |
| Changed in canonical-devices-system-image: | |
| status: | In Progress → Fix Committed |
| Changed in canonical-devices-system-image: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
This bug was fixed in the package webbrowser-app - 0.23+16.
---------------
webbrowser-app (0.23+16.
[ CI Train Bot ]
* Resync trunk.
[ Olivier Tilloy ]
* Add keyboard navigation support to narrow views (new tab view,
history view, bookmarks view, downloads view). (LP: #1539221)
* Add video-specific contextual actions. (LP: #1539676)
* Take a capture of the current page shortly after it has finished
loading to give rendering an opportunity to complete. (LP: #1540129)
* Use the new bottom edge bar to open the tabs view in autopilot
tests.
-- Olivier Tilloy <email address hidden> Mon, 15 Feb 2016 13:33:21 +0000