New collectd subordinate charm
Bug #1538573 reported by
Jacek Nykis
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Juju Charms Collection |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
I wrote new collectd subordinate charm using the charm.reactive framework. I would like it to be a "recommended" charm so can I have please review for it?
The charm was tested using mojo but it currently does not have amulet tests. I tried writing them but I hit multiple problems doing that because my charm uses "juju-info" relation (and nobody in #juju was able to help).
Could I please get:
1. Review of the charm
2. Advice on how to write amulet tests
Related branches
Changed in charms: | |
status: | Triaged → New |
Changed in charms: | |
status: | In Progress → New |
Changed in charms: | |
status: | Fix Committed → In Progress |
Changed in charms: | |
status: | Fix Committed → New |
description: | updated |
To post a comment you must log in.
Hi,
We would like to thank you for your time and effort you put into this charm.
It would be great if you could submit the repo with the layer you implemented in addition to the charm build output? This would make the review process much easier. /code.launchpad .net/~jacekn/ canonical- is-charms/ collectd- composer , right?
Guess it is this one https:/
In respect to your tests failing, we found the problem to be in line: http:// bazaar. launchpad. net/~jacekn/ charms/ trusty/ collectd/ trunk/view/ head:/tests/ 99-autogen# L14 relate( 'ubuntu: juju-info' , 'collectd:host')
You should a) be referencing explicitely the relation name for ubuntu and b) use the interface name of collectd.
So the line at hand should look like this: cls.deployment.
Can you also please make sure your "make test" is successful? You could use bundletester https:/ /github. com/juju- solutions/ bundletester to ensure your charm is ready.
Here are some additional comments we find important:
- We do not recomend using a hook to trap config changes. /code.launchpad .net/~johnsca/ charms/ trusty/ collectd/ layer-rq
Many thanks to Cory Johns who tried to refactor your charm:
https:/
- For subordinate charms we recommend you use the option: /github. com/johnsca/ layer-apache- hadoop- plugin/ commit/ 861031a3a07a03e d6589065d1c59c4 0cbd1cdf9e
options:
basic:
use_venv: true
In this way your subordinate charm will not conflict with the pricipal one as it will operate in a virtual environment.
Have a look here: https:/
Many thanks to Cary John, and Kevin Monroe who helped in the review.
Thank you for your time,
Konstantinos