Rabbit ha queues variable cannot be set directly through puppet

[Nitish Krishna Kaveri]

The rabbit ha queues param in neutron config is set by checking if rabbit_hosts param is set.
An upcoming change will mean that rabbit_hosts will ALWAYS be set.
Need to investigate in which scenarios rabbit ha queues are needed and set them accordingly, if needed might have to modify the neutron init.pp file

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/16422
Submitter: Nitish Krishna Kaveri (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/16422
Committed: http://github.org/Juniper/contrail-puppet/commit/845edc6b59531713aea780b7fc7925b2d3bbcd0c
Submitter: Zuul
Branch: master

commit 845edc6b59531713aea780b7fc7925b2d3bbcd0c
Author: nitishkrishna <email address hidden>
Date: Fri Jan 22 10:48:17 2016 -0800

Closes-Bug: #1536375 - HA provisioning failed due to neutron config errors

Wrong if condition
Rabbit port redeclaration of param error
Rabbit Ha queues cannot be set directly (Refer bug 1536753)

Change-Id: I639bb86e8386333e6e0e2968d6059dda265ae044

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/15138
Submitter: Nitish Krishna Kaveri (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/15138
Committed: http://github.org/Juniper/contrail-puppet/commit/6fa8beb53cfbbd85c30bfc978e985c32418fb5cb
Submitter: Zuul
Branch: master

commit 6fa8beb53cfbbd85c30bfc978e985c32418fb5cb
Author: nitishkrishna <email address hidden>
Date: Mon Feb 1 10:10:12 2016 -0800

Server-Manager Provisioning changes for rabbit ip:port list change

Changing the contrail config files to use ip:port list
for rabbit_server knob instead of rabbit_server and rabbit_port
with vip and haproxy frontend port.
Closes-Bug: #1515773 - Rabbit HA change
Closes-Bug: #1536753 - Rabbit HA queues never set

Accompanies commit: https://review.opencontrail.org/#/c/15076/

Patch 2:
Added openstack files deleting the setting of rabbit_port per Thilak response

Patch 3:
Changed all config of rabbit_host to rabbit_hosts, verified that rabbit_hosts is available as a config option

Patch 4:
Added user specified amqp_ip_list and amqp_port to params (Used to set contrail_rabbit_servers)

Patch 5:
Added rabbitmq.pp as separate manifest as part of config to allow rabbitmq to be provisioned conditionally based on amqp_ip_list supplied by user.
Removed rabbit mq provisioning from config/config.pp and moved to config/rabbitmq.pp

Patch 6:
Added separate openstack_amqp_ip_list and contrail_amqp_ip_list for user to be able to configure separate rabbitmq clusters for config and opentack nodes.

Patch 7:
Redid after puppet refactoring changes

Patch 8:
Fixed bugs in uuid (rabbitmq clustering), params, init.pp, neutron and haproxy

Patch 9:
Changed defaults for amqp_port,list,etc - new params introduced.
Defaults changed from false to ''.
Change-Id: I1c916ca4bcc455f877d3f77fda9a69d3442d6754