Admin user search returns no results when results exist

[Robert Lyon]

There is a scenario where you can get 'No results found' message and 'X results' at the same time

To replicate:

- Have a database with many users in it, say 100
- Have 5 users only with the same last name

Go to the Administration -> Users -> User search page (admin/users/search.php)

Go to the last page of users in pagination

Now type in the 'Search: (All institutions)' box the name you want to search for and click 'Search'

You should see 'No results found' message but also '5 results' at the same time

This is because the search is trying to use the pagination offset rather than beginning at offset 0

[Robert Lyon (robertl-9)]

There is a [WAR] cb (lib/searchlib.php:332) Invalid argument supplied for foreach() shown for this problem

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/5954

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/5954
Committed: https://git.mahara.org/mahara/mahara/commit/8d571ebb92c1745afc2417b405fecf669bd86fae
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit 8d571ebb92c1745afc2417b405fecf669bd86fae
Author: Robert Lyon <email address hidden>
Date: Thu Jan 21 16:27:50 2016 +1300

Bug 1536452: Admin user search giving wrong results

When paginating then searching

See bug for testing info

behatnotneeded

Change-Id: I344cdfe28aee0f8182cfa6214f4dd9611f5666c1
Signed-off-by: Robert Lyon <email address hidden>

[Mahara Bot (dev-mahara)]

Patch for "16.04_STABLE" branch: https://reviews.mahara.org/6424

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/6424
Committed: https://git.mahara.org/mahara/mahara/commit/bff104abe4bde1194954c2b1e1d81e73bd0fc88a
Submitter: Aaron Wells (<email address hidden>)
Branch: 16.04_STABLE

commit bff104abe4bde1194954c2b1e1d81e73bd0fc88a
Author: Robert Lyon <email address hidden>
Date: Thu Jan 21 16:27:50 2016 +1300

Bug 1536452: Admin user search giving wrong results

When paginating then searching

See bug for testing info

behatnotneeded

Change-Id: I344cdfe28aee0f8182cfa6214f4dd9611f5666c1
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 8d571ebb92c1745afc2417b405fecf669bd86fae)