Address bar does not get focus when adding a new tab
Bug #1533317 reported by
Kugi Eusebio
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Canonical Pocket Desktop |
Fix Released
|
Medium
|
Bill Filler | ||
Canonical System Image |
Fix Released
|
Medium
|
Bill Filler | ||
webbrowser-app (Ubuntu) |
Fix Released
|
Medium
|
Olivier Tilloy |
Bug Description
Expected Result:
When adding a new tab via the button or Ctrl + T, the address bar is automatically focused so that users can immediately type the URL.
Current Result:
When opening a new tab, the new tab page is shown with bookmarks and top sites but the user can't type immediately the URL they want to go to.
This might be more appropriate in windowed mode since most likely a physical keyboard exists thus making it easier for the users to input the URL when adding a new tab. In staged mode, focusing the address bar will show the OSK which might not be desirable if the user wants to select from the bookmarks or top sites instead of inputting its own URL.
Related branches
lp:~osomon/webbrowser-app/autofocus-addressbar-wide
- PS Jenkins bot: Needs Fixing (continuous-integration)
- Ubuntu Phablet Team: Pending requested
-
Diff: 413 lines (+84/-59)6 files modifiedsrc/app/webbrowser/Browser.qml (+42/-12)
tests/autopilot/webbrowser_app/tests/__init__.py (+4/-5)
tests/autopilot/webbrowser_app/tests/test_keyboard.py (+9/-11)
tests/autopilot/webbrowser_app/tests/test_private.py (+2/-3)
tests/autopilot/webbrowser_app/tests/test_sad_tab.py (+6/-6)
tests/autopilot/webbrowser_app/tests/test_tabs.py (+21/-22)
tags: | added: convergence |
Changed in webbrowser-app (Ubuntu): | |
status: | Confirmed → In Progress |
Changed in canonical-pocket-desktop: | |
status: | New → In Progress |
Changed in canonical-devices-system-image: | |
status: | New → In Progress |
Changed in canonical-devices-system-image: | |
status: | In Progress → Fix Committed |
Changed in canonical-devices-system-image: | |
status: | Fix Committed → Fix Released |
Changed in canonical-pocket-desktop: | |
status: | In Progress → Fix Released |
To post a comment you must log in.
Thanks for the detailed report!
This is the intended behaviour: as you point out, on a phone form-factor, focusing the address bar would pop up the OSK, which would partially hide the new tab view. On a desktop, in windowed mode, the address bar gets focused.
Currently the "desktop mode" detection is clunky and won’t work well on unity8, but that’s a separate issue. As far as focusing the address bar, the behaviour is correct.