default availability zones in nova.conf are not set for nova::api

[Dale Smith]

There are three configuration params in nova.conf related to availability zones:
default_schedule_zone
default_availability_zone
internal_service_availability_zone

These are currently set with puppet-nova on the nova::compute class, which may not be installed on the same node as nova-api.
https://review.openstack.org/#/c/187396/

Here is an example of the issue in my development environment: http://paste.openstack.org/raw/482629/

I've not been able to conclusively find out which nova daemons the params are used in, but there are two options to resolve this:
- move these config stanzas to the nova class in init.pp for all nova daemons
- include the stanzas in only the nova-* daemons that use them. nova-api may be one of many that require them.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/261313

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/261313
Committed: https://git.openstack.org/cgit/openstack/puppet-nova/commit/?id=605a9d90e2a98afedffba8b498575d022a44b9b2
Submitter: Jenkins
Branch: master

commit 605a9d90e2a98afedffba8b498575d022a44b9b2
Author: Dale Smith <email address hidden>
Date: Thu Dec 24 12:34:30 2015 +0000

    Move availability zone parameters to their own class.

    Several nova-* services require these parameters, nova::compute is too specific
    for these parameters and may not be included on all nodes.

    Change-Id: Iec4ace333a0f33118609267aab5c0974f62807df
    Closes-Bug: #1529065

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/689267

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/689267
Committed: https://git.openstack.org/cgit/openstack/puppet-nova/commit/?id=d7eb253e4de03c05eb6597db0959e4137831ad91
Submitter: Zuul
Branch: master

commit d7eb253e4de03c05eb6597db0959e4137831ad91
Author: Oliver Walsh <email address hidden>
Date: Thu Oct 17 21:43:43 2019 +0100

    Include nova::availability_zone in nova::api and nova::conductor

    For some reason this was included in nova::compute and nova::scheduler
    but never included in nova::api eventhough bug #1529065 specifically
    calls out the fact that it is missing.

    Looking at the code - nova-api definitely requires it.
    E.g the server create request handler sets the target AZ to
    CONF.default_schedule_zone if none
    https://github.com/openstack/nova/blob/stable/queens/nova/api/openstack/compute/servers.py#L486

    and the az request handler skips the internal_service_availabily_zone
    when listing AZs
    https://github.com/openstack/nova/blob/stable/queens/nova/api/openstack/compute/availability_zone.py#L38

    nova-conductor also requires it as it calls
    availability_zones.get_host_availability_zone which defaults to
    CONF.default_availability_zone

    Change-Id: If4d6a4a8f4cc1e7066cacb00da67d5433acd6ac5
    Closes-bug: #1529065

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/691121

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/691121
Committed: https://git.openstack.org/cgit/openstack/puppet-nova/commit/?id=57ff2a154c0e50da4a833ffabfef27a8d0db4fb6
Submitter: Zuul
Branch: stable/train

commit 57ff2a154c0e50da4a833ffabfef27a8d0db4fb6
Author: Oliver Walsh <email address hidden>
Date: Thu Oct 17 21:43:43 2019 +0100

    Include nova::availability_zone in nova::api and nova::conductor

    For some reason this was included in nova::compute and nova::scheduler
    but never included in nova::api eventhough bug #1529065 specifically
    calls out the fact that it is missing.

    Looking at the code - nova-api definitely requires it.
    E.g the server create request handler sets the target AZ to
    CONF.default_schedule_zone if none
    https://github.com/openstack/nova/blob/stable/queens/nova/api/openstack/compute/servers.py#L486

    and the az request handler skips the internal_service_availabily_zone
    when listing AZs
    https://github.com/openstack/nova/blob/stable/queens/nova/api/openstack/compute/availability_zone.py#L38

    nova-conductor also requires it as it calls
    availability_zones.get_host_availability_zone which defaults to
    CONF.default_availability_zone

    Change-Id: If4d6a4a8f4cc1e7066cacb00da67d5433acd6ac5
    Closes-bug: #1529065
    (cherry picked from commit d7eb253e4de03c05eb6597db0959e4137831ad91)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/691471

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/691471
Committed: https://git.openstack.org/cgit/openstack/puppet-nova/commit/?id=75d67bd6c8ff0fd147e1ac7516ede2bc60d960b2
Submitter: Zuul
Branch: stable/stein

commit 75d67bd6c8ff0fd147e1ac7516ede2bc60d960b2
Author: Oliver Walsh <email address hidden>
Date: Thu Oct 17 21:43:43 2019 +0100

    Include nova::availability_zone in nova::api and nova::conductor

    For some reason this was included in nova::compute and nova::scheduler
    but never included in nova::api eventhough bug #1529065 specifically
    calls out the fact that it is missing.

    Looking at the code - nova-api definitely requires it.
    E.g the server create request handler sets the target AZ to
    CONF.default_schedule_zone if none
    https://github.com/openstack/nova/blob/stable/queens/nova/api/openstack/compute/servers.py#L486

    and the az request handler skips the internal_service_availabily_zone
    when listing AZs
    https://github.com/openstack/nova/blob/stable/queens/nova/api/openstack/compute/availability_zone.py#L38

    nova-conductor also requires it as it calls
    availability_zones.get_host_availability_zone which defaults to
    CONF.default_availability_zone

    Change-Id: If4d6a4a8f4cc1e7066cacb00da67d5433acd6ac5
    Closes-bug: #1529065
    (cherry picked from commit d7eb253e4de03c05eb6597db0959e4137831ad91)
    (cherry picked from commit 57ff2a154c0e50da4a833ffabfef27a8d0db4fb6)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/691676

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/691676
Committed: https://git.openstack.org/cgit/openstack/puppet-nova/commit/?id=effda25202c9270b843e113c12edef5b80130559
Submitter: Zuul
Branch: stable/rocky

commit effda25202c9270b843e113c12edef5b80130559
Author: Oliver Walsh <email address hidden>
Date: Thu Oct 17 21:43:43 2019 +0100

    Include nova::availability_zone in nova::api and nova::conductor

    For some reason this was included in nova::compute and nova::scheduler
    but never included in nova::api eventhough bug #1529065 specifically
    calls out the fact that it is missing.

    Looking at the code - nova-api definitely requires it.
    E.g the server create request handler sets the target AZ to
    CONF.default_schedule_zone if none
    https://github.com/openstack/nova/blob/stable/queens/nova/api/openstack/compute/servers.py#L486

    and the az request handler skips the internal_service_availabily_zone
    when listing AZs
    https://github.com/openstack/nova/blob/stable/queens/nova/api/openstack/compute/availability_zone.py#L38

    nova-conductor also requires it as it calls
    availability_zones.get_host_availability_zone which defaults to
    CONF.default_availability_zone

    Change-Id: If4d6a4a8f4cc1e7066cacb00da67d5433acd6ac5
    Closes-bug: #1529065
    (cherry picked from commit d7eb253e4de03c05eb6597db0959e4137831ad91)
    (cherry picked from commit 57ff2a154c0e50da4a833ffabfef27a8d0db4fb6)
    (cherry picked from commit 75d67bd6c8ff0fd147e1ac7516ede2bc60d960b2)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/691831

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/691831
Committed: https://git.openstack.org/cgit/openstack/puppet-nova/commit/?id=a47853c485a13c30800170fc133f0aa6a6c78acb
Submitter: Zuul
Branch: stable/queens

commit a47853c485a13c30800170fc133f0aa6a6c78acb
Author: Oliver Walsh <email address hidden>
Date: Thu Oct 17 21:43:43 2019 +0100

    Include nova::availability_zone in nova::api and nova::conductor

    For some reason this was included in nova::compute and nova::scheduler
    but never included in nova::api eventhough bug #1529065 specifically
    calls out the fact that it is missing.

    Looking at the code - nova-api definitely requires it.
    E.g the server create request handler sets the target AZ to
    CONF.default_schedule_zone if none
    https://github.com/openstack/nova/blob/stable/queens/nova/api/openstack/compute/servers.py#L486

    and the az request handler skips the internal_service_availabily_zone
    when listing AZs
    https://github.com/openstack/nova/blob/stable/queens/nova/api/openstack/compute/availability_zone.py#L38

    nova-conductor also requires it as it calls
    availability_zones.get_host_availability_zone which defaults to
    CONF.default_availability_zone

    Change-Id: If4d6a4a8f4cc1e7066cacb00da67d5433acd6ac5
    Closes-bug: #1529065
    (cherry picked from commit d7eb253e4de03c05eb6597db0959e4137831ad91)
    (cherry picked from commit 57ff2a154c0e50da4a833ffabfef27a8d0db4fb6)
    (cherry picked from commit 75d67bd6c8ff0fd147e1ac7516ede2bc60d960b2)
    (cherry picked from commit effda25202c9270b843e113c12edef5b80130559)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-nova 16.0.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-nova queens-eol release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-nova rocky-eol release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-nova stein-eol release.