[CentOS7] Changes in feature groups are applied only second restart of nailgun container

[Dmitriy Kruglov]

Fuel version: 8.0, build 288.
Changes made in feature groups via amending /etc/fuel/astute.yaml are applied only after second restart of nailgun container.

1. Check current feature groups (e.g. via 'fuel fuel-version' request):
[root@nailgun ~]# fuel fuel-version
api: '1'
auth_required: true
feature_groups: []
openstack_version: 2015.1.0-8.0
release: '8.0'

2. Update /etc/fuel/astute.yaml file, "FEATURE_GROUPS" list. Specify the required advanced/ experimental features to enable.
[root@nailgun ~]# cat /etc/fuel/astute.yaml | grep -A1 FEATURE
"FEATURE_GROUPS":
  - "advanced"

3. Restart nailgun container and check feature groups data.
[root@nailgun ~]# dockerctl restart nailgun
fuel-core-8.0-nailgun
[root@nailgun ~]# fuel fuel-version
api: '1'
auth_required: true
feature_groups: []
openstack_version: 2015.1.0-8.0
release: '8.0'

Expected result: new features are enabled.

4. Once more, restart nailgun container and check feature groups data:
[root@nailgun ~]# dockerctl restart nailgun
fuel-core-8.0-nailgun
[root@nailgun ~]# fuel fuel-version
api: '1'
auth_required: true
feature_groups:
- advanced
openstack_version: 2015.1.0-8.0
release: '8.0'

[Artem Panchenko (apanchenko-8)]

Related bug #1526917.

When Nailgun container is re-started, systemd starts Nailgun service and start.sh (start-container.service) simultaneously , so its configuration isn't updated by puppet at that moment. There are two issues here:

1) nailgun.service (and others [0]) is started before applying puppet manifests
2) puppet doesn't reload services if their configuration is changed

[0] https://github.com/openstack/fuel-library/blob/master/deployment/puppet/nailgun/examples/nailgun-only.pp#L171-L180

[Bogdan Dobrelya (bogdando)]

This applies here as well https://bugs.launchpad.net/fuel/+bug/1526787/comments/5
If containers were ordinary service units, nothing would have broken with service ordering as it works out of box in systemd

[Matthew Mosesohn (raytrac3r)]

This just means we need to refresh the service when updating config in puppet. This should have been the case to begin with.

[Dmitry Teselkin (teselkin-d)]

It's a task for a team that supports puppet manifests, so it can't be assigned to mos-linux.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/260958

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/260958
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=64ba708d34b9d2922d62d1c8d8115b2623b01fdc
Submitter: Jenkins
Branch: master

commit 64ba708d34b9d2922d62d1c8d8115b2623b01fdc
Author: Matthew Mosesohn <email address hidden>
Date: Wed Dec 23 14:24:41 2015 +0300

    Refresh nailgun systemd units if settings.yaml is updated

    This was caused by starting systemd services before applying
    Puppet, which prevented Puppet changes to settings from taking
    effect immediately.

    Change-Id: I24f766f74a67018ae7c9120558ff3a102c1ab404
    Closes-Bug: #1526874

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/261266

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/261266
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=3cc8d3e9c0231320c6a0ccd1bb235dc2929a2279
Submitter: Jenkins
Branch: master

commit 3cc8d3e9c0231320c6a0ccd1bb235dc2929a2279
Author: Matthew Mosesohn <email address hidden>
Date: Thu Dec 24 10:57:22 2015 +0000

    Refresh nailgun systemd units if settings.yaml is updated

    This was caused by starting systemd services before applying
    Puppet, which prevented Puppet changes to settings from taking
    effect immediately.

    Change-Id: I9f644b829601b68182b397989e43bf4f80773975
    Closes-Bug: #1526874

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/8.0
Review: https://review.openstack.org/261975

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/261975
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=5456d4427a8bbfe7a54e1ee6f56f7f34e3b1c91c
Submitter: Jenkins
Branch: stable/8.0

commit 5456d4427a8bbfe7a54e1ee6f56f7f34e3b1c91c
Author: Matthew Mosesohn <email address hidden>
Date: Thu Dec 24 10:57:22 2015 +0000

    Refresh nailgun systemd units if settings.yaml is updated

    This was caused by starting systemd services before applying
    Puppet, which prevented Puppet changes to settings from taking
    effect immediately.

    Change-Id: I9f644b829601b68182b397989e43bf4f80773975
    Closes-Bug: #1526874
    (cherry picked from commit 3cc8d3e9c0231320c6a0ccd1bb235dc2929a2279)

[Dmitriy Kruglov (dkruglov)]

Verified on MOS 8.0, build 405. The issue is fixed.

ISO details:
VERSION:
  feature_groups:
    - mirantis
  production: "docker"
  release: "8.0"
  api: "1.0"
  build_number: "405"
  build_id: "405"
  fuel-nailgun_sha: "9ebbaa0473effafa5adee40270da96acf9c7d58a"
  python-fuelclient_sha: "4f234669cfe88a9406f4e438b1e1f74f1ef484a5"
  fuel-agent_sha: "df16d41cd7a9445cf82ad9fd8f0d53824711fcd8"
  fuel-nailgun-agent_sha: "92ebd5ade6fab60897761bfa084aefc320bff246"
  astute_sha: "c7ca63a49216744e0bfdfff5cb527556aad2e2a5"
  fuel-library_sha: "037ca95820aac8214fe65e7e0461074e1cf6891c"
  fuel-ostf_sha: "214e794835acc7aa0c1c5de936e93696a90bb57a"
  fuel-mirror_sha: "8bb8c70efc61bcf633e02d6054dbf5ec8dcf6699"
  fuelmenu_sha: "2a0def56276f0fc30fd949605eeefc43e5d7cc6c"
  shotgun_sha: "63645dea384a37dde5c01d4f8905566978e5d906"
  network-checker_sha: "9f0ba4577915ce1e77f5dc9c639a5ef66ca45896"
  fuel-upgrade_sha: "616a7490ec7199f69759e97e42f9b97dfc87e85b"
  fuelmain_sha: "62573cb2a8aa54845de9303b4a30935a90e1db61"