Get rid of obsolete option "disablelogin" in lib/db/version.php
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mahara |
Fix Released
|
Low
|
Aaron Wells |
Bug Description
There's some very old code in the Mahara upgrader that looks at $config-
I think the intent behind adding this, was to allow the version.php to indicate whether the upgrade is a big enough change that users need to be logged out during it. This makes a certain sense if used in combination with strict discipline in testing and updating $config-
However, in practice, we've had "disablelogin" set to true since 2008. And given how many Mahara versions there are now, it's safer just to force users to log out, as we have been doing for the past 7 years.
So I think it'd be best to remove this bit of code, since we never use it.
Changed in mahara: | |
status: | Confirmed → Fix Committed |
Changed in mahara: | |
assignee: | nobody → Aaron Wells (u-aaronw) |
Changed in mahara: | |
status: | Fix Committed → Fix Released |
Patch for "master" branch: https:/ /reviews. mahara. org/5851