Doesn't let you share several images

Bug #1523573 reported by Sebastien Bacher
30
This bug affects 6 people
Affects Status Importance Assigned to Milestone
Canonical System Image
Fix Released
High
Bill Filler
camera-app (Ubuntu)
Fix Released
High
Ugo Riboni
gallery-app (Ubuntu)
Fix Released
High
Arthur Mello
messaging-app (Ubuntu)
Fix Released
High
Tiago Salem Herrmann

Bug Description

Using ota8 on bq devices, the share menu is disabled when more than one image is selected.

Related branches

Revision history for this message
Sebastien Bacher (seb128) wrote :

Being able to select a bunch of pictures on facebook seems something users do quite often nowadays and we got some grumpy user comments, could be worth trying to do for ota9 if it's easy enough? (Ken said that the content-hub has a multiselection mode so it's not a framework limitation)

Revision history for this message
Sebastien Bacher (seb128) wrote :

In fact that seems done on purpose, the code in PhotogridView has

" enabled: model.selectedFiles.length <= 1"

is the reason for that limitation still standing? (it's not stated with a comment so unsure why it's there)

Note that if you come from e.g dekko you can select several images and it works so it seems the feature is working

Changed in canonical-devices-system-image:
assignee: nobody → Bill Filler (bfiller)
importance: Undecided → High
milestone: none → backlog
status: New → Confirmed
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in camera-app (Ubuntu):
status: New → Confirmed
Changed in gallery-app (Ubuntu):
status: New → Confirmed
Revision history for this message
Bill Filler (bfiller) wrote :

iirc, if we are initiating the share from the gallery app we purposely limited to 1 selection (possibly the same in camera?) because messaging-app could only handle a single attachment at a time (and think this is still the case). I don't know if content-hub api specifies a way for the source app to know whether or not the destination app supports multiple files in this case. I suppose we could allow multi-selection and if the destination app doesn't support it, it should notify the user.

I believe if another app requests the import from the gallery (i.e. dekko asks to attach images) then gallery should honor the multi-select request from content-hub.

Revision history for this message
Bill Filler (bfiller) wrote :

@artmello, @uriboni
Please remove the restriction for single selection for sharing. But please test sharing with messaging-app and make sure it doesn't break if you try to share multiple photos. For now expected behavior of messaging-app would be to just show first photo until we add support for sending multiple photos in that app.

Changed in canonical-devices-system-image:
milestone: backlog → ww08-2016
Changed in gallery-app (Ubuntu):
importance: Undecided → High
assignee: nobody → Arthur Mello (artmello)
Changed in camera-app (Ubuntu):
importance: Undecided → High
assignee: nobody → Ugo Riboni (uriboni)
Changed in messaging-app (Ubuntu):
importance: Undecided → High
status: New → Confirmed
assignee: nobody → Tiago Salem Herrmann (tiagosh)
Revision history for this message
Bill Filler (bfiller) wrote :

@tiagosh
Please add support for handling multiple photos shared from gallery/camera->messaging-app

Revision history for this message
Bill Filler (bfiller) wrote :

@tiagosh
And also when pressing the attach button in messaging-app it should set the multipleFiles flag to true in the content-hub api such that it works in this direction as well

Revision history for this message
Bill Filler (bfiller) wrote :

@tiagosh
same is true for videos and contacts, should handle multi-select in both directions

Arthur Mello (artmello)
Changed in gallery-app (Ubuntu):
status: Confirmed → In Progress
Changed in messaging-app (Ubuntu):
status: Confirmed → In Progress
Changed in canonical-devices-system-image:
status: Confirmed → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package messaging-app - 0.1+16.04.20160224-0ubuntu1

---------------
messaging-app (0.1+16.04.20160224-0ubuntu1) xenial; urgency=medium

  * Enable receiving multiple files from content-hub. (LP: #1523573)
  * Makes text in the swipe demo use relative positioning instead of
    absolute. (LP: #1518344)
  * Remove all line breaks from the text message preview and set a
    maximum line count, so the Text component correctly respect the
    elide property. (LP: #1532895)
  * Set width based on the screen size to avoid removing views from the
    stack when the app is resized. (LP: #1549352)

 -- Tiago Salem Herrmann <email address hidden> Wed, 24 Feb 2016 18:29:28 +0000

Changed in messaging-app (Ubuntu):
status: In Progress → Fix Released
Changed in canonical-devices-system-image:
status: In Progress → Fix Committed
Changed in camera-app (Ubuntu):
status: Confirmed → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gallery-app - 0.0.67+16.04.20160323.1-0ubuntu1

---------------
gallery-app (0.0.67+16.04.20160323.1-0ubuntu1) xenial; urgency=medium

  [ Arthur Mello ]
  * Enable sharing multiple files Notify user when trying to share
    photos and videos at the same time (LP: #1523573)
  * Set Window flag instead of Window state to toggle fullscreen mode
    for media viewer (LP: #1535397)

  [ CI Train Bot ]
  * Resync trunk. added: po/sk.po

 -- Arthur Mello <email address hidden> Wed, 23 Mar 2016 18:03:08 +0000

Changed in gallery-app (Ubuntu):
status: In Progress → Fix Released
Changed in canonical-devices-system-image:
status: Fix Committed → Fix Released
Changed in camera-app (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.