deere skin should remember settings

[Foss-4]

reproduce:

- adjust some skin specific settings using the top right hamburger menu option using deere skin
- switch to latenight skin
- switch back to deere again

currently:

all settings are back to default. this is very annoying, since deere currently lacks a few features (e.g. passthrough option), so users may have to switch skins here and there. but everytime all settings are lost.

expected:

deere skin should save settings in some file and remember those settings. switching the skins should not affect any skin related settings which were previously made.

[jus (jus)]

what settings exactly are not saved?

> On Dec 4, 2015, at 8:17 PM, Foss-4 <email address hidden> wrote:
>
> Public bug reported:
>
> reproduce:
>
> - adjust some skin specific settings using the top right hamburger menu option using deere skin
> - switch to latenight skin
> - switch back to deere again
>
> currently:
>
> all settings are back to default. this is very annoying, since deere
> currently lacks a few features (e.g. passthrough option), so users may
> have to switch skins here and there. but everytime all settings are
> lost.
>
> expected:
>
> deere skin should save settings in some file and remember those
> settings. switching the skins should not affect any skin related
> settings which were previously made.
>
> ** Affects: mixxx
> Importance: Undecided
> Status: New
>
> --
> You received this bug notification because you are a member of Mixxx
> Development Team, which is subscribed to Mixxx.
> https://bugs.launchpad.net/bugs/1522939
>
> Title:
> deere skin should remember settings
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/1522939/+subscriptions

[Foss-4 (foss-4)]

e.g hiding the crossfader

[jus (jus)]

Also ``Show Cover Art``, see lp:1531990

[jus (jus)]

Also Cover art selection does not persist when switching Waveforms, see lp:1523381

[Foss-4 (foss-4)]

jus, just a ping on this. where you able to look into this? is this a hard to solve issue?

[ronso0 (ronso0)]

Am I right that this is only about missing persist="true" in the <ConfigKey>?
If so, I'd like to fix it and double-check all other options controlled from skin_settings.xml

[JosepMa (josepma)]

Tried it, these settings are not maintained in the user scenario:

* Opened/closed skin settings bar
show mixer
* show crossfader
show microphone
show 4 decks
maximize library
show cover art
* conceal artist/track info
* conceal BPM Info
(samplers)Show advanced mode
(effects)show advanced mode

The options marked with an asterisk (*) do not have the persist=true. The other do.

It might happen that the settings not supported by the intermediate skin (latenight in this case) might forget its status.

[ronso0 (ronso0)]

What I've learned is: if every skin-wide occurance of i.e. [SkinName],show_something has persist="true" attached, it's value will be stored in mixxx.cfg.
Some controls might be temporary on purpose (like show_skinsettings or hide_mixer) if the skin designer want's this to be the standard view when reloading the skin or launching Mixxx.
So, basically every setting can be made permanent but the skin designer has to decide which should and which should not.

For lp:1531990 adding currentpage="[CoverArt],current" to <WidgetStack> should help, right?
If yes, I would tackle that bug(s).

[Foss-4 (foss-4)]

just my thoughts:

should be customizable and setting remembered:

VIEW
* show crossfader
* show microphone
* show preview deck
* show 4 decks
* show cover art in library

MAIN DECKS
* show cover art (two different options to be remembered specifically)
* show star ratings
* show more hotcues
* conceal artist / track info
* conceal bpm info
* show stacked waveforms
* show vinyl control options

SAMPLERS
* show advanced mode

EFFECT RACK
* show advanced mode

I don't see why any of the above should not be remembered. Either a user uses timecode vinyl or not. If they do, they likely want those options displayed. Or not, but please please please let the user decide what UI options they need.

I feel that not remembering those settings will highly annoy users.

I have no knowledge about how the code behaves.

@Ronny: it would be greatly appreciated, if you could give this a spin. Maybe it's worth to just try out your changes and then see if mixxx behaves as desired.

[Be (be.ing)]

https://github.com/mixxxdj/mixxx/pull/940

[Foss-4 (foss-4)]

fix verified. thanks a lot Be.

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/8360