non-free RFC file in qtbase patch

[Jonathan Riddell]

The patch enable-tests contains a non-free RFC file which can not be modified.

As a community made free software project Ubuntu has a policy that everything in main should be free to copy and share and modify
"Must allow modification and distribution of modified copies under the same licence."

There is an exception for documentation which could be said to cover this, in which case an exception should be asked for with justification given.

As the patch is a modified version of the RFC it is arguably illegal to distribute.

This causes problems for Debian who do not want DFSG non-free patches in their Git repository where this is stored and of course are unable to merge and upload with this patch.

Easiest would be just to remove the patch.

[Dmitry Shachnev (mitya57)]

The whole patch is huge (it contains *all* changes related to tests enablement), so we can't drop it altogether. Instead we can remove the parts related to RFC files and disable the corresponding tests.

Dropping the RFC parts will also make it easier to copy this patch to Debian, in case someone wants to do that.

[Steve Langasek (vorlon)]

If the RFC is modified, then yes, there is most likely no right to distribute. The standard license on the RFCs specifically prohibits modification. (This is a dubious requirement for the IETF to impose, but we still need to respect the license.)

I was unaware that there was a question about the RFC being modified. This makes it very urgent that this bug be dealt with.

[Dmitry Shachnev (mitya57)]

I think it's not modified, and Jonathan's concern was just about its license. The patch is AFAIK used just as data file for some tests (definitely not the best choice for such things).

[Timo Jyrinki (timo-jyrinki)]

I've checked that the RFC files that are added back in the patch (deleted from the upstream sources in the +dfsg orig tarball) are unmodified from the IETF versions.

I'll proceed on checking the options of removing them anyway because it'd be nice to consider getting Debian using the tests too (and because I do value free software purity).

[Launchpad Janitor (janitor)]

This bug was fixed in the package qtbase-opensource-src - 5.5.1+dfsg-6ubuntu4

---------------
qtbase-opensource-src (5.5.1+dfsg-6ubuntu4) xenial; urgency=medium

  * Update symbols for s390x.

 -- Timo Jyrinki <email address hidden> Tue, 08 Dec 2015 13:35:46 +0000

[Timo Jyrinki (timo-jyrinki)]

qtbase-opensource-src (5.5.1+dfsg-6ubuntu3) xenial; urgency=medium

  * debian/patches/enable-tests.patch:
    - Replace the non-DFSG-free RFC files with public domain content.
    - Adjust tests to the new files.
    (LP: #1522442)
  * debian/copyright: mention the replacement.
  * Switch to opt-in for architectures to run tests on.

 -- Timo Jyrinki <email address hidden> Mon, 07 Dec 2015 14:02:11 +0000

qtbase-opensource-src (5.5.1+dfsg-6ubuntu2) xenial; urgency=high

  * Skip largefile test on s390x too, in addition to amd64.
  * Make tests to keep going till the end with -k.

 -- Dimitri John Ledkov <email address hidden> Fri, 04 Dec 2015 16:54:28 +0000

qtbase-opensource-src (5.5.1+dfsg-6ubuntu1) xenial; urgency=medium

  * New upstream release. (LP: #1437206) (LP: #1450137) (LP: #1474313)
    (LP: #1470700) (LP: #1504631) (LP: #1423659) (LP: #1474775) (LP: #1508945)
  * Replace load_testability_from_env_var.patch with upstreamed
    Add-environment-variable-support-for-testability-lib.patch
  * Drop patches in upstream:
    - Correct-typo-in-the-Gujarati-openType-identififer.patch
  * Rebase enable-tests.patch. Disable one failing QtWidgets test.
  * Build depend on GStreamer 1.0 and add a configure option for it.
  * Update symbols.
  * Mark/unmark private symbols.
  * Replace two Ubuntu patches with upstreamed patches:
    - Drop disable-generic-plugin-when-others-available.patch, replace with
      Add-an-option-to-skip-the-generic-bearer-engine.patch
    - Drop qopenglframebufferobject_powervrworkaround.patch, replace with
      Blacklist-PowerVR-Rogue-G6200-v1.3-from-supporting-B.patch
  * debian/patches/Make-sure-networkAccessibilityChanged-is-emitted.patch:
    - Include a network fix from Qt 5.5 branch (merged after 5.5.1)
      (LP: #1470700)
  * debian/patches/Use-Node-name-if-Node-logicalModuleName-is-empty-for.patch:
    - Fix a qdoc issue (LP: #1447182)
  * Remove disable_overlay_scrollbars.diff as overlay scrollbars were dropped.
  * debian/patches/Prefer-QT_PLUGIN_PATH-over-compiled-in-paths.patch:
    - Backport. Prefer QT_PLUGIN_PATH over compiled-in paths (LP: #1519927)
  * debian/patches/Fix-crash-on-exit-caused-by-QStringLiterals.patch
    - Backport. Fix a crasher on exit (LP: #1436973)
  * Replace our workaround for font rendering with new backported upstream
    patches:
    - Add debian/patches/Fix-falsely-reported-style-for-fallback-font.patch
    - Add debian/patches/Remove-historical-4-padding-in-QFontEngine-alphaMapF.patch
    - Remove debian/patches/enable_fonts_always_smoothly.patch
      (LP: #1475205)

 -- Timo Jyrinki <email address hidden> Tue, 01 Dec 2015 06:16:35 +0000