Duplicate Title Error on Wiki Page Edit

[Nat Katin-Borland]

This issue was reported by a user. Wiki pages with the following titles seem to trigger duplicate page errors on edit. So you can create the page, but if you try to subsequently edit it, then the duplicate error is thrown (see screenshot). Titles:

Strategy Budget Operations: Implementation & Reflection Phase: Strategy Support Sheets
Strategy Budget Operations: Implementation & Reflection Phase: Strategy & Budget Modification

You can also see from the screenshot that KARL thinks the page is already being edited by me, which is a bit strange.

I have recreated the issue in a test community:

https://karl.soros.org/communities/a-time-for-testing-again/wiki/strategy-budget-operations-implementation-reflection-phase-strategy-support-sheets/
https://karl.soros.org/communities/a-time-for-testing-again/wiki/strategy-budget-operations-implementation-reflection-phase-strategy-budget-modification/

In case you need it, here are the original pages:

https://karl.soros.org/communities/strategy-unit/wiki/strategy-budget-operations-implementation-reflection-phase-strategy-support-sheets/
https://karl.soros.org/communities/strategy-unit/wiki/strategy-budget-operations-implementation-reflection-phase-strategy-budget-modification/

Some ideas - number of characters in the title? Special characters (: &) in the title?

Please investigate.

Thanks,
Nat

[Paul Everitt (paul-agendaless)]

Carlos, since this is reproducible, can you take a look at it locally? It doesn't log any traceback of any kind, so you'll have to set a breakpoint and walk through it.

[Nat Katin-Borland (nborland)]

Here's a screenshot of another error the same user is receving when the try to edit a page with a "/" in the title with a ":". Screenshot attached. Just in case this is helpful.

[Paul Everitt (paul-agendaless)]

Let's try to get this one out the door soon.

[Carlos de la Guardia (cguardia)]

This was surprisingly difficult to track. Turns out the stripogram library we use inside karl has a page limit of 80 characters by default. When a wiki page title has a length greater than this number *and* includes an ampersand anywhere in the title, a new line character is added to the title, which causes the wiki to think for a moment (because it compares a stripped title with the one with a new line) that there is no page with that title. It then tries to create new page with that title, but the newline is stripped and there is the name collision.

Long story short, page width should never be a part of the equation in a title, so I simply made the default 110, ensuring that it never will be surpassed by a title (because max length is 100).

Still, I have not yet found out why the ampersand causes that problem. I think we can safely ignore the reason, though.

[Carlos de la Guardia (cguardia)]

One more thing, the fix onkly works for new pages, because the pages that have this problem already have the newline as part of the title. It will be necessary to edit the title to fix them (add a period, for example).

[Paul Everitt (paul-agendaless)]

Very well done. Do you think we need to do a bin/debug script that dumps all the URLs for the ones with the problem? Perhaps we then need to take some action..mangle the name automatically with a period, as you say, but perhaps that breaks some wikilinks.

—Paul

> On Dec 15, 2015, at 4:44 AM, Carlos de la Guardia <email address hidden> wrote:
>
> One more thing, the fix onkly works for new pages, because the pages
> that have this problem already have the newline as part of the title. It
> will be necessary to edit the title to fix them (add a period, for
> example).
>
> --
> You received this bug notification because you are subscribed to KARL4.
> Matching subscriptions: KARL4
> https://bugs.launchpad.net/bugs/1521326
>
> Title:
> Duplicate Title Error on Wiki Page Edit
>
> Status in KARL4:
> Fix Committed
>
> Bug description:
> This issue was reported by a user. Wiki pages with the following
> titles seem to trigger duplicate page errors on edit. So you can
> create the page, but if you try to subsequently edit it, then the
> duplicate error is thrown (see screenshot). Titles:
>
> Strategy Budget Operations: Implementation & Reflection Phase: Strategy Support Sheets
> Strategy Budget Operations: Implementation & Reflection Phase: Strategy & Budget Modification
>
> You can also see from the screenshot that KARL thinks the page is
> already being edited by me, which is a bit strange.
>
> I have recreated the issue in a test community:
>
> https://karl.soros.org/communities/a-time-for-testing-again/wiki/strategy-budget-operations-implementation-reflection-phase-strategy-support-sheets/
> https://karl.soros.org/communities/a-time-for-testing-again/wiki/strategy-budget-operations-implementation-reflection-phase-strategy-budget-modification/
>
> In case you need it, here are the original pages:
>
> https://karl.soros.org/communities/strategy-unit/wiki/strategy-budget-operations-implementation-reflection-phase-strategy-support-sheets/
> https://karl.soros.org/communities/strategy-unit/wiki/strategy-budget-operations-implementation-reflection-phase-strategy-budget-modification/
>
> Some ideas - number of characters in the title? Special characters (:
> &) in the title?
>
> Please investigate.
>
> Thanks,
> Nat
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/karl4/+bug/1521326/+subscriptions

[Nat Katin-Borland (nborland)]

I think we can manually edit the few pages if necessary. I don't think it's that many pages (at least as far as I know).