Mahara

Group journals tab isn't using the proper API

Bug #1512942 reported by Aaron Wells
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Low
Aaron Wells
Mahara 16.04.0

Bug Description

While investigating some group-related issues, I noticed that the new group journals tab was hard-coded into the group_get_menu_tabs() method, instead of using the PluginArtefact::group_tabs() api method (like the Files artefact does).

Tags: blog groups
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/5655

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5655
Committed: https://git.mahara.org/mahara/mahara/commit/c75120b4d2d22433653e38e19368bb0c30dfac31
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit c75120b4d2d22433653e38e19368bb0c30dfac31
Author: Aaron Wells <email address hidden>
Date: Wed Nov 4 17:51:04 2015 +1300

Use the right artefact API for group journal tab (Bug 1512942)

Also fixing a long-standing unnoticed bug in the group menu
method. Each item has a "weight", but the items are never
sorted by weight. They were just used in the order they were
inserted, which coincidentally matched their weight order.

behatnotneeded: Results won't be visible from the front-end

Change-Id: Ib56aaedfd494401336fb11443ce6495f6dfe4cb5

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Kristina Hoeppner (kris-hoeppner)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.