Mahara

"My portfolios" block still says "X pages"

Bug #1511238 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Robert Lyon
Mahara 16.04.0
15.10
Fix Released
Medium
Unassigned
Mahara 15.10.1

Bug Description

15.10+

The page count on the "My portfolios" block still says "Pages" although there are now also collections shown. It will be better to just say "1 results" or "x results".

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/5647

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5647
Committed: https://git.mahara.org/mahara/mahara/commit/d0834d60ff853a936ad3445568b1e5d52882530e
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit d0834d60ff853a936ad3445568b1e5d52882530e
Author: Robert Lyon <email address hidden>
Date: Fri Oct 30 12:58:35 2015 +1300

Bug 1511238: Using the correct string to indicate results

Now that pages and collections are displayed we want to show 'X results'

behatnotneeded: showing 'pages' vs 'results' doesn't break functionality

Change-Id: Ib658a5d7e0586dd371b08b980808a0accd59db52
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "15.10_STABLE" branch: https://reviews.mahara.org/5662

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5662
Committed: https://git.mahara.org/mahara/mahara/commit/798ff1c2aca78caee315584b3175604ecaacb9c1
Submitter: Aaron Wells (<email address hidden>)
Branch: 15.10_STABLE

commit 798ff1c2aca78caee315584b3175604ecaacb9c1
Author: Robert Lyon <email address hidden>
Date: Fri Oct 30 12:58:35 2015 +1300

Bug 1511238: Using the correct string to indicate results

Now that pages and collections are displayed we want to show 'X results'

behatnotneeded: showing 'pages' vs 'results' doesn't break functionality

Change-Id: Ib658a5d7e0586dd371b08b980808a0accd59db52
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit d0834d60ff853a936ad3445568b1e5d52882530e)

Kristina Hoeppner (kris-hoeppner)
no longer affects: mahara/16.04
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.