status check does not tolerate ENOENT if ringlefile not yet created

[Edward Hope-Morley]

Recently added assess_status() causes this by calling has_minimum_zones() which errors if rings do not exist yet. Should be easy enough to fix.

2015-10-28 10:00:45 INFO swift-storage-relation-joined Traceback (most recent call last):
2015-10-28 10:00:45 INFO swift-storage-relation-joined File "/var/lib/juju/agents/unit-swift-proxy-1/charm/hooks/swift-storage-relation-joined", line 537, in <module>
2015-10-28 10:00:45 INFO swift-storage-relation-joined main()
2015-10-28 10:00:45 INFO swift-storage-relation-joined File "/var/lib/juju/agents/unit-swift-proxy-1/charm/hooks/swift-storage-relation-joined", line 533, in main
2015-10-28 10:00:45 INFO swift-storage-relation-joined assess_status(CONFIGS)
2015-10-28 10:00:45 INFO swift-storage-relation-joined File "/var/lib/juju/agents/unit-swift-proxy-1/charm/hooks/lib/swift_utils.py", line 1054, in assess_status
2015-10-28 10:00:45 INFO swift-storage-relation-joined if not has_minimum_zones(rings):
2015-10-28 10:00:45 INFO swift-storage-relation-joined File "/var/lib/juju/agents/unit-swift-proxy-1/charm/hooks/lib/swift_utils.py", line 1020, in has_minimum_zones
2015-10-28 10:00:45 INFO swift-storage-relation-joined builder = _load_builder(ring).to_dict()
2015-10-28 10:00:45 INFO swift-storage-relation-joined File "/var/lib/juju/agents/unit-swift-proxy-1/charm/hooks/lib/swift_utils.py", line 377, in _load_builder
2015-10-28 10:00:45 INFO swift-storage-relation-joined builder = pickle.load(open(path, 'rb'))
2015-10-28 10:00:45 INFO swift-storage-relation-joined IOError: [Errno 2] No such file or directory: '/etc/swift/account.builder'
2015-10-28 10:00:45 ERROR juju.worker.uniter.operation runhook.go:103 hook "swift-storage-relation-joined" failed: exit status 1

[Edward Hope-Morley (hopem)]

Seems this has already been fixed in /next - http://bazaar.launchpad.net/~openstack-charmers/charms/trusty/swift-proxy/next/revision/121. I'll proceed with backporting it.

[Andreas Hasenack (ahasenack)]

The ingestion of the fixed charm into the charm store is blocked on https://bugs.launchpad.net/launchpad/+bug/1510993

[Adam Collard (adam-collard)]

The Landscape configuration where this failed looked like this:

config={"replicas": "3",
               "zone-assignment": "auto",
               "openstack-origin": "trusty-kilo"}

Juju version was 1.24.6, deploying charm version swift-proxy-24

[Ryan Beisner (1chb1n)]

FWIW, the charm's functional tests use the default/recommended zone-assignment value of 'manual.' The other full deploy and mojo-driven tests also exercise only manual zone-assignment. A new mojo spec test could be defined to specifically exercise the auto zone-assignment scenario.