Regression in tracking merged merge proposals
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| | Launchpad itself |
Critical
|
Colin Watson | ||
Bug Description
Reference: OOPS-65fc797001ee794b1322c898bc1021e2
16:40 < zyga> cjwatson: https:/
16:43 < cjwatson> OOPS-65fc797001ee794b1322c898bc1021e2
16:44 < cjwatson> it's noticed it but then something went wrong just before marking it as merged
Related branches
- Colin Watson: Approve on 2015-10-28
-
Diff: 89 lines (+47/-0)2 files modifieddatabase/schema/security.cfg (+1/-0)
lib/lp/code/model/tests/test_gitjob.py (+46/-0)
| Colin Watson (cjwatson) wrote : | #1 |
| tags: | added: branch-scanner code-review oops regression |
| Changed in launchpad: | |
| status: | New → In Progress |
| importance: | Undecided → Critical |
| assignee: | nobody → Colin Watson (cjwatson) |
| summary: |
- Regression in tracking merged git merge requests + Regression in tracking merged merge proposals |
| Launchpad QA Bot (lpqabot) wrote : | #2 |
Fixed in stable r17838 <http://
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| Colin Watson (cjwatson) wrote : | #3 |
I haven't got this working on qastaging yet, but the offending feature flag has now been turned back off and so you shouldn't see this on production any more. I'll try to make extra-double-sure it works properly before turning it back on again ...
| Changed in launchpad: | |
| status: | Fix Committed → In Progress |
| Colin Watson (cjwatson) wrote : | #4 |
The reason I couldn't get this to work on qastaging was that the process of applying permission changes to the database went wrong! I worked with webops today to get that sorted out and merge detection now works fine on qastaging with my patch and with this feature flag turned on.
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Released |
I think this may have more to do with the fact that it's private than that it's git. Here's a similar case for bzr: OOPS-d27f9c927b110da1b72dfe0d7a485a06