deploy_cinder_net_tmpl system test failed with Error code 500 ['NoneType' object has no attribute 'vlan_start']

[Maksym Strukov]

Scenario (https://mirantis.testrail.com/index.php?/tests/view/1932944)
1. Revert snapshot with 3 slaves
2. Create cluster (HA) with Neutron VLAN/VXLAN/GRE
3. Add 1 controller + cinder nodes
4. Add 2 compute + cinder nodes
5. Upload 'cinder' network template'

Actual:
HTTP Error 500: Internal Server Error ['NoneType' object has no attribute 'vlan_start']

Env:
Fuel 8.0-51 (liberty)

[Tatyanka (tatyana-leontovich)]

looks like api changes here https://review.openstack.org/#/c/232021/8 affected this case too

[Alexander Saprykin (cutwater)]

Where does this exception appear?

In case of CLI (python-fuelclient) we merged fix for client https://review.openstack.org/#/c/238083/ on 27th of October.

[Alexander Saprykin (cutwater)]

This is a duplicate for bug https://bugs.launchpad.net/fuel/+bug/1508423

[Alexander Saprykin (cutwater)]

Update: Wrong bug. This is not duplicate. Working on it. Requires further investigation.

[Alexander Saprykin (cutwater)]

Looks like this failure was caused by this patchset https://review.openstack.org/#/c/221542/

It fails due to non exist network groups on line nailgun/network/neutron.py:395

            # Default admin network has no node group
            if network == consts.NETWORKS.fuelweb_admin:
                net_db = cls.get_admin_network_group(node.id)
            else:
                net_db = objects.NetworkGroup.get_from_node_group_by_name(
                    node.group_id, network)

            # Ensure network_group configuration is consistent
            # with the template
            if vlan != net_db.vlan_start:
                net_db.vlan_start = vlan
                db().add(net_db)
                db().flush()

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/243224

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/243224
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=f2acf7328fb25b1f9b55743c269128780cec5870
Submitter: Jenkins
Branch: master

commit f2acf7328fb25b1f9b55743c269128780cec5870
Author: Ryan Moe <email address hidden>
Date: Mon Nov 9 08:50:01 2015 -0800

    Check for existence of network group when uploading template

    Network groups can be created at any time so there is no guarantee
    that it will exist when a template is uploaded. Before updating the
    network group's VLAN the existence of the network group is checked.

    Networks are reassigned for all nodes when a new network group is
    created. A new pre-deployment check was added to validate that all
    network groups required by a network template exist.

    Change-Id: I28d3df4db0fe69f5b4fc9af491f0aae1f695901f
    Closes-bug: #1509543

[Tatyanka (tatyana-leontovich)]

verified VERSION:
  feature_groups:
    - mirantis
  production: "docker"
  release: "8.0"
  openstack_version: "2015.1.0-8.0"
  api: "1.0"
  build_number: "212"
  build_id: "212"
  fuel-nailgun_sha: "13d1800be2452bd297555eedf051bda469b5663b"
  python-fuelclient_sha: "4f9a873b1ae68271bb848a1145b3cf912a176f4b"
  fuel-agent_sha: "f0e09fa7a30b5ab87e901601bfb6c1e339a6bdaa"
  fuel-nailgun-agent_sha: "b56f832abc18aee9a8c603fd6cc2055c5f4287bc"
  astute_sha: "d2c1b401816c6f0341902272f37018b9cec3c775"
  fuel-library_sha: "c892d2919620947225687ccde63d0e038784f0a2"
  fuel-ostf_sha: "5cf8c484a9a4f45f353468438cf98f1b5a5c5dfb"
  fuel-createmirror_sha: "9b335c8d551c87d788166947cb7ed519757881e8"
  fuelmenu_sha: "9627849843e84b7f01c44bd79898a8d62d96ce66"
  shotgun_sha: "34a081508b603723e14f9415a62373be39f3685f"
  network-checker_sha: "2c62cd52655ea6456ff6294fd63f18d6ea54fe38"
  fuel-upgrade_sha: "1e894e26d4e1423a9b0d66abd6a79505f4175ff6"
  fuelmain_sha: "daed38102b6074393821d675e3d7d866fcdb3da5"