Network configuration handler in nailgun changed API, python-fuelclient did not follow

[Maciej Kwiek]

Commit c87470bf9c4fbd622ff443a786b96d8c2dc619b9 in fuel-web introduced a change in API, which was not taken into account in fuelclient.

Running fuel network --env-id 1 --upload ends up with an error:

Traceback (most recent call last):
  File "/usr/bin/fuel", line 10, in <module>
    sys.exit(main())
  File "/usr/lib/python2.6/site-packages/fuelclient/cli/error.py", line 114, in wrapper
    return func(*args, **kwargs)
  File "/usr/lib/python2.6/site-packages/fuelclient/cli/parser.py", line 266, in main
    parser.parse()
  File "/usr/lib/python2.6/site-packages/fuelclient/cli/parser.py", line 143, in parse
    actions[parsed_params.action].action_func(parsed_params)
  File "/usr/lib/python2.6/site-packages/fuelclient/cli/actions/base.py", line 62, in action_func
    method(params)
  File "/usr/lib/python2.6/site-packages/fuelclient/cli/actions/network.py", line 58, in upload
    if task_result['status'] == 'error':
KeyError: 'status'

[Sebastian Kalinowski (prmtl)]

Here is the revert: https://review.openstack.org/238030

1) Many, many times it was mentioned to do not change what this API is returning if you do not get rid of "task" from this API handler. So it is completly wrong approach.

2) Nobody check if fuelclient working. You change API, you need to check it.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/238083

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/238083
Committed: https://git.openstack.org/cgit/openstack/python-fuelclient/commit/?id=2a1b048cc439986e222ece43a290b5cc68e92a77
Submitter: Jenkins
Branch: master

commit 2a1b048cc439986e222ece43a290b5cc68e92a77
Author: Alexander Saprykin <email address hidden>
Date: Wed Oct 21 15:29:16 2015 +0200

    Fix network upload in CLI

    Fix network upload due to API update.

    Change-Id: I8b8c013fe9689423304168c2050264fe67f5f124
    Closes-Bug: #1508423

[Dmitry Belyaninov (dbelyaninov)]

Verified on ISO #172.
Environment created by dos.py script.

Running "upload" command for the network ends up successfully:
[root@nailgun home]# fuel --env 1 network --upload --dir .
Network configuration uploaded.

VERSION:
  feature_groups:
    - mirantis
  production: "docker"
  release: "8.0"
  openstack_version: "2015.1.0-8.0"
  api: "1.0"
  build_number: "172"
  build_id: "172"
  fuel-nailgun_sha: "f8ba3f9cd449363f1c08621307e7504c304c29ae"
  python-fuelclient_sha: "e685d68c1c0d0fa0491a250f07d9c3a8d0f9608c"
  fuel-agent_sha: "61f741f4d89a3f1095dd8b494f82695fb69153d6"
  fuel-nailgun-agent_sha: "3e9d17211d65c80bf97c8d83979979f6c7feb687"
  astute_sha: "959b06c5ef8143125efd1727d350c050a922eb12"
  fuel-library_sha: "31aa9fb129a8b8739f8ca6ea186caa3c9f46820f"
  fuel-ostf_sha: "9690a2de829d3b063ed1e64b0b10dde39f711dc0"
  fuel-createmirror_sha: "22a7aacd95bbdca69f9e0f08b70facabdec8fb28"
  fuelmenu_sha: "06bbcebed6c8d0b0f9279e2997d2f958c800e98c"
  shotgun_sha: "c377d163519f6d10b69a654019d6086ba5f14edc"
  network-checker_sha: "a57e1d69acb5e765eb22cab0251c589cd76f51da"
  fuel-upgrade_sha: "1e894e26d4e1423a9b0d66abd6a79505f4175ff6"
  fuelmain_sha: "266f9b374934c64629a84b5146632cc0de70ac91"