l23networks fails unit tests with rspec-puppet ~> 2.2

[Alex Schultz]

We're getting failures in l23network for the get_network_role_property and get_transformation_property tests when the unit tests are run on openstack-infra.

2015-10-22 18:40:34.308 | Failures:
2015-10-22 18:40:34.308 |
2015-10-22 18:40:34.308 | 1) function_get_network_role_property mtk should return NIL for "admin" network role
2015-10-22 18:40:34.308 | Failure/Error: should run.with_params('admin', 'phys_dev').and_return(nil)
2015-10-22 18:40:34.308 | expected get_network_role_property("admin", "phys_dev") to have returned nil instead of ["eth0"]
2015-10-22 18:40:34.308 | # ./spec/functions/get_network_role_property__spec.rb:94:in `block (3 levels) in <top (required)>'
2015-10-22 18:40:34.308 |
2015-10-22 18:40:34.308 | 2) function_get_transformation_property get_transformation_property('some_property', 'transformation') usage should return NIL for "eth2" transformation
2015-10-22 18:40:34.308 | Failure/Error: should run.with_params('mtu', 'eth2').and_return(nil)
2015-10-22 18:40:34.308 | expected get_transformation_property("mtu", "eth2") to have returned nil instead of 1024
2015-10-22 18:40:34.309 | # ./spec/functions/get_transformation_property__spec.rb:120:in `block (3 levels) in <top (required)>'

http://logs.openstack.org/64/238564/4/check/gate-fuel-library-puppet-unit-3.3-dsvm-centos7/4fffc03/console.html#_2015-10-22_18_40_34_308

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/238680

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/238680
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=ac715526ff82d8a36dab4a724b371f628887aad2
Submitter: Jenkins
Branch: master

commit ac715526ff82d8a36dab4a724b371f628887aad2
Author: Alex Schultz <email address hidden>
Date: Thu Oct 22 14:53:49 2015 -0500

    Fix tests for l23network

    This change includes an update to rspec-puppet ~> 2.2 and adjusting the
    two tests that fail under 2.2 but not 2.1. I believe these failures are
    related to https://github.com/rodjek/rspec-puppet/issues/266

    The get_network_role_properly was previously passing because the return
    value was not be properly check. In the code we are returning eth0 as
    the interface for the admin network role and not nil.

    The get_transformation_property was previously passing because the
    return value was not correctly checked. Based on the code, the value for
    eth2 should have been 1024 while the value for eth3 would have been nil.
    This change updates the eth2 check with 1024 and adds a test case for
    eth3.

    Change-Id: I7b87d02d4c702dde68ecd7f4abcd304e686fa795
    Closes-Bug: #1509056

[Nastya Urlapova (aurlapova)]

http://logs.openstack.org/60/279160/2/check/gate-fuel-library-puppet-unit-3.3-dsvm-centos7/2113912/