remove hardcoded network roles from manifests

[Vasyl Saienko]

At the moment some manifests contain hardcoded network roles:

$ grep "get_node_to_ipaddr_map_by_network_role(get_nodes_hash_by_roles" * -R
deployment/puppet/osnailyfacter/modular/openstack-haproxy/openstack-haproxy-heat.pp:$heat_address_map = get_node_to_ipaddr_map_by_network_role(get_nodes_hash_by_roles($network_metadata, hiera('heat_roles')), 'heat/api')
deployment/puppet/osnailyfacter/modular/openstack-haproxy/openstack-haproxy-sahara.pp:$sahara_address_map = get_node_to_ipaddr_map_by_network_role(get_nodes_hash_by_roles($network_metadata, hiera('sahara_roles')), 'sahara/api')
deployment/puppet/osnailyfacter/modular/openstack-haproxy/openstack-haproxy-keystone.pp:$keystones_address_map = get_node_to_ipaddr_map_by_network_role(get_nodes_hash_by_roles($network_metadata, ['primary-controller', 'controller']), 'keystone/api')
deployment/puppet/osnailyfacter/modular/openstack-haproxy/openstack-haproxy-murano.pp:$murano_address_map = get_node_to_ipaddr_map_by_network_role(get_nodes_hash_by_roles($network_metadata, hiera('murano_roles')), 'murano/api')
deployment/puppet/osnailyfacter/modular/openstack-haproxy/openstack-haproxy-glance.pp:$glances_address_map = get_node_to_ipaddr_map_by_network_role(get_nodes_hash_by_roles($network_metadata, ['primary-controller', 'controller']), 'glance/api')

they should be replaced with globals like:
deployment/puppet/osnailyfacter/modular/openstack-haproxy/openstack-haproxy-cinder.pp:$cinder_address_map = get_node_to_ipaddr_map_by_network_role(hiera_hash('cinder_nodes'), 'cinder/api')

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/258155

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/258155
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=aacacc9bf9736c971d62bff872e197df39e33325
Submitter: Jenkins
Branch: master

commit aacacc9bf9736c971d62bff872e197df39e33325
Author: Maksim Malchuk <email address hidden>
Date: Wed Dec 30 18:59:50 2015 +0300

    Remove hardcoded network roles from HAproxy manifests

    This commit removed some hardcoded network roles from HAproxy manifests
    and replaces them with globals. Also it fixes hiera override functionality
    for some globals.

    Change-Id: Ia6006b19f366cec8ac686e19e7b921e95051c1ac
    Closes-Bug: #1505604

[Timur Nurlygayanov (tnurlygayanov)]

Looks like it works fine since we don't have any issues with network interfaces.
Status changed to Fix Released for MOS 8.0