Error messages regarding missing packages should be able to be pasted into the apt-get command directly
Bug #1505386 reported by
Mike Pontillo
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| MAAS |
Fix Released
|
Medium
|
Jeffrey C Jones | ||
Bug Description
When adding an Intel AMT today, I received the following error:
To control power with this power type, install the 'amtterm, wsmancli' package(s) on cluster 'maas'.
It would be nice if the error could call out the specific "apt-get install <package1> [[package2] ...]" command, rather than giving me a comma-separated list. (since in 90% of cases the next action will probably involve opening SSH toward the affected cluster and installing packages)
Related branches
lp:~trapnine/maas/power-package-checks
- Gavin Panella (community): Approve
-
Diff: 804 lines (+319/-23)15 files modifiedsrc/maasserver/api/tests/test_enlistment.py (+6/-0)
src/maasserver/api/tests/test_node.py (+3/-0)
src/maasserver/clusterrpc/power.py (+45/-3)
src/maasserver/clusterrpc/power_parameters.py (+2/-0)
src/maasserver/models/node.py (+25/-2)
src/maasserver/models/tests/test_node.py (+30/-1)
src/maasserver/static/js/angular/controllers/node_details.js (+36/-5)
src/maasserver/static/partials/node-details.html (+15/-4)
src/provisioningserver/power/change.py (+11/-0)
src/provisioningserver/power/query.py (+11/-0)
src/provisioningserver/power/tests/test_change.py (+48/-3)
src/provisioningserver/power/tests/test_query.py (+45/-4)
src/provisioningserver/rpc/cluster.py (+21/-0)
src/provisioningserver/rpc/clusterservice.py (+11/-0)
src/provisioningserver/rpc/tests/test_clusterservice.py (+10/-1)
| Changed in maas: | |
| milestone: | none → 1.9.0 |
Revision history for this message
| Jeffrey C Jones (trapnine) wrote | #1 |
Revision history for this message
| Mike Pontillo (mpontillo) wrote | #2 |
| Changed in maas: | |
| assignee: | nobody → Jeffrey C Jones (trapnine) |
| status: | Triaged → In Progress |
| Changed in maas: | |
| status: | In Progress → Fix Committed |
| Changed in maas: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Perhaps changing the output from comma-separated to space-separated would suffice (to make it easy to cut and paste to apt-get).
Thoughts:
- The required items will not always be apt installable. For example, IBM has their own HMC software package you download from them directly. The error for that looks like: "To proceed, install the 'HMC Management Software' package(s) on cluster 'maas'". To provide apt commands for the right drivers means the drivers have to know which are available via apt and which aren't, then format the responses in a more complex way to communicate the difference. Currently the low lever checkers provide a list of missing strings to install (human understandable software names), which gets piped up to the UI.
- The user may have an alternate method of installing software on their maas cluster, making our suggestion extra noise and incorrect. If they don't know apt-get, will they know how to ssh there to run the command, and should we put sudo in front?