Fix end of rib logic in channel to handle all message types

[Tapan Karwa]

Fix end of rib logic in channel to handle all message types.

Currently, to determine that we have received all data, we were depending the message type 'SearchResult'.

But, there can be cases, where the first batch of data is received in an 'UpdateResult' i.e. when the connection to the ifmap-server goes up, ifmap-server does not have any data to begin with. Then, later when config is added, the data will come in as an 'UpdateResult'. The code is processing the EOR logic only for SearchResults which is incorrect.

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/14130
Submitter: Tapan Karwa (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/14131
Submitter: Tapan Karwa (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/14130
Committed: http://github.org/Juniper/contrail-controller/commit/471dd174a2f19736f81664ffd953e68ca37adb09
Submitter: Zuul
Branch: master

commit 471dd174a2f19736f81664ffd953e68ca37adb09
Author: Tapan Karwa <email address hidden>
Date: Wed Sep 30 09:54:03 2015 -0700

Fix end of rib logic in channel to handle all message types.

Currently, to determine that we have received all data, we were depending the
message type 'SearchResult'.

But, there can be cases, where the first batch of data is received in an
'UpdateResult' i.e. when the connection to the ifmap-server goes up,
ifmap-server does not have any data to begin with. Then, later when config is
added, the data will come in as an 'UpdateResult'. The code is processing the
EOR logic only for SearchResults which is incorrect. Fixing that.

Change-Id: I0106c62e8bec2cbf06a25efc1856451273d7df1f
Closes-Bug: #1501425

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/14131
Committed: http://github.org/Juniper/contrail-controller/commit/08866ba87d5e898c27e3e053e82ccdcfd8fec056
Submitter: Zuul
Branch: R2.20

commit 08866ba87d5e898c27e3e053e82ccdcfd8fec056
Author: Tapan Karwa <email address hidden>
Date: Wed Sep 30 09:54:03 2015 -0700

Fix end of rib logic in channel to handle all message types.

Currently, to determine that we have received all data, we were depending the
message type 'SearchResult'.

But, there can be cases, where the first batch of data is received in an
'UpdateResult' i.e. when the connection to the ifmap-server goes up,
ifmap-server does not have any data to begin with. Then, later when config is
added, the data will come in as an 'UpdateResult'. The code is processing the
EOR logic only for SearchResults which is incorrect. Fixing that.

Change-Id: I0106c62e8bec2cbf06a25efc1856451273d7df1f
Closes-Bug: #1501425

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/20025
Submitter: Nischal Sheth (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/20026
Submitter: Nischal Sheth (<email address hidden>)

[Nischal Sheth (nsheth)]

R3.0 and master status was updated unintentionally due
to commit for bug 1527551. Restored them to original.

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/20025
Submitter: Nischal Sheth (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/20026
Submitter: Nischal Sheth (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/20025
Committed: http://github.org/Juniper/contrail-controller/commit/b4f5f3679f684a4ea82f86ffc71270abeaf4f020
Submitter: Zuul
Branch: master

commit b4f5f3679f684a4ea82f86ffc71270abeaf4f020
Author: Nischal Sheth <email address hidden>
Date: Sun May 8 20:46:18 2016 -0700

Refine stale cleanup and EOR heuristics

Restart stale cleanup and EOR timers only if we receive searchResult.
If we receive updateResult or deleteResult, artificially expire the
relevant timers right away.

This handles the corner case where continuous object add/delete can
keep the CN from becoming active.

Note that this fix does not reintroduce bug 1501425.

Change-Id: Ib2f790d323f28c8403f8bcf20ba18fa782a03967
Closes-Bug: 1527551

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/20026
Committed: http://github.org/Juniper/contrail-controller/commit/4c1f1de97a7f2fc9d03b3de24e586cbcba24fe23
Submitter: Zuul
Branch: R3.0

commit 4c1f1de97a7f2fc9d03b3de24e586cbcba24fe23
Author: Nischal Sheth <email address hidden>
Date: Sun May 8 20:46:18 2016 -0700

Refine stale cleanup and EOR heuristics

Restart stale cleanup and EOR timers only if we receive searchResult.
If we receive updateResult or deleteResult, artificially expire the
relevant timers right away.

This handles the corner case where continuous object add/delete can
keep the CN from becoming active.

Note that this fix does not reintroduce bug 1501425.

Change-Id: Ib2f790d323f28c8403f8bcf20ba18fa782a03967
Closes-Bug: 1527551