TypeError on None value for CommaDelimitedListParam

[James Pic]

When doing a heat stack-show, heat-api crashes because the __str__ method isn't prepared for self.parsed to be None:

2015-09-28 14:49:08.975 14782 ERROR root [req-6968958a-ef92-4d27-8e14-1b161074f220 ] Exception handling resource:
Traceback (most recent call last):

  File "/usr/lib/python2.7/site-packages/oslo/messaging/rpc/dispatcher.py", line 134, in _dispatch_and_reply
    incoming.message))

  File "/usr/lib/python2.7/site-packages/oslo/messaging/rpc/dispatcher.py", line 177, in _dispatch
    return self._do_dispatch(endpoint, method, ctxt, args)

  File "/usr/lib/python2.7/site-packages/oslo/messaging/rpc/dispatcher.py", line 123, in _do_dispatch
    result = getattr(endpoint, method)(ctxt, **new_args)

  File "/usr/lib/python2.7/site-packages/heat/engine/service.py", line 69, in wrapped
    return func(self, ctx, *args, **kwargs)

  File "/usr/lib/python2.7/site-packages/heat/engine/service.py", line 469, in show_stack
    return [api.format_stack(stack) for stack in stacks]

  File "/usr/lib/python2.7/site-packages/heat/engine/api.py", line 97, in format_stack
    api.STACK_PARAMETERS: stack.parameters.map(str),

  File "/usr/lib/python2.7/site-packages/heat/engine/parameters.py", line 482, in map
    for n, p in six.iteritems(self.params) if filter_func(p))

  File "/usr/lib/python2.7/site-packages/heat/engine/parameters.py", line 482, in <genexpr>
    for n, p in six.iteritems(self.params) if filter_func(p))

  File "/usr/lib/python2.7/site-packages/heat/engine/parameters.py", line 363, in __str__
    return ",".join(self.value())

TypeError

I noticed this seems to happen after a stack-update call was made without a parameter that was used in a stack-create call.

[James Pic (jamespic)]

I'm still trying to isolate the bug in a minimal template, the use case
described in the bug above is incorrect - my bad. If it helps I'd like to
contribute a patch with a test case and a fix, let me know.

Le lun. 28 sept. 2015 16:30, Rabi Mishra <email address hidden> a
écrit :

> ** Changed in: heat
> Assignee: (unassigned) => Rabi Mishra (rabi)
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1500452
>
> Title:
> TypeError on None value for CommaDelimitedListParam
>
> Status in heat:
> New
>
> Bug description:
> When doing a heat stack-show, heat-api crashes because the __str__
> method isn't prepared for self.parsed to be None:
>
> 2015-09-28 14:49:08.975 14782 ERROR root
> [req-6968958a-ef92-4d27-8e14-1b161074f220 ] Exception handling resource:
> Traceback (most recent call last):
>
> File
> "/usr/lib/python2.7/site-packages/oslo/messaging/rpc/dispatcher.py", line
> 134, in _dispatch_and_reply
> incoming.message))
>
> File
> "/usr/lib/python2.7/site-packages/oslo/messaging/rpc/dispatcher.py", line
> 177, in _dispatch
> return self._do_dispatch(endpoint, method, ctxt, args)
>
> File
> "/usr/lib/python2.7/site-packages/oslo/messaging/rpc/dispatcher.py", line
> 123, in _do_dispatch
> result = getattr(endpoint, method)(ctxt, **new_args)
>
> File "/usr/lib/python2.7/site-packages/heat/engine/service.py", line
> 69, in wrapped
> return func(self, ctx, *args, **kwargs)
>
> File "/usr/lib/python2.7/site-packages/heat/engine/service.py", line
> 469, in show_stack
> return [api.format_stack(stack) for stack in stacks]
>
> File "/usr/lib/python2.7/site-packages/heat/engine/api.py", line 97,
> in format_stack
> api.STACK_PARAMETERS: stack.parameters.map(str),
>
> File "/usr/lib/python2.7/site-packages/heat/engine/parameters.py",
> line 482, in map
> for n, p in six.iteritems(self.params) if filter_func(p))
>
> File "/usr/lib/python2.7/site-packages/heat/engine/parameters.py",
> line 482, in <genexpr>
> for n, p in six.iteritems(self.params) if filter_func(p))
>
> File "/usr/lib/python2.7/site-packages/heat/engine/parameters.py",
> line 363, in __str__
> return ",".join(self.value())
>
> TypeError
>
> I noticed this seems to happen after a stack-update call was made
> without a parameter that was used in a stack-create call.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/heat/+bug/1500452/+subscriptions
>

[Rabi Mishra (rabi)]

sure. please assign it to yourself, I you plan to work on it,

[Sergey Kraynev (skraynev)]

@James: As I see, you still work on this, but did not upload fix. So I move it to M2 milestone.

[James Pic (jamespic)]

Thanks for the notification, I couldn't find the link anymore, so here's my problem: I just can't reproduce it anymore ! Unassigning

[Peter Razumovsky (prazumovsky)]

Looks like patch https://review.openstack.org/#/c/234055/ fix this issue, because now self.parsed updated with default value correctly. This patch also backported to L and K releases.