test_scheduler_multi_instance fails once in a while

[Renat Akhmerov]

http://logs.openstack.org/59/222159/7/gate/gate-mistral-python27/6e11234/testr_results.html.gz

[Nikolay Makhotkin (nmakhotkin)]

Can not reproduce this bug yet using Mistral cluster or using Mistral cluster with manual putting call to the scheduler.

I tend to think the problem is due to we use mocks in those tests and they are invoked simultenously more than 1 time.

[Nikolay Makhotkin (nmakhotkin)]

Not only the one test fails. test_scheduler_with_factory, test_scheduler_without_factory also fail once in a while. But these tests don't assume we have multi instance scheduler. Here is a concurrency problem.

======================================================================
FAIL: mistral.tests.unit.services.test_scheduler.SchedulerServiceTest.test_scheduler_without_factory
tags: worker-2
----------------------------------------------------------------------
Empty attachments:
  pythonlogging:''
  stderr
  stdout

Traceback (most recent call last):
  File "/home/kolyan/projects/mistral/.tox/py27/local/lib/python2.7/site-packages/mock/mock.py", line 1305, in patched
    return func(*args, **keywargs)
  File "mistral/tests/unit/services/test_scheduler.py", line 119, in test_scheduler_without_factory
    method.assert_called_once_with(name='task', id='321')
  File "/home/kolyan/projects/mistral/.tox/py27/local/lib/python2.7/site-packages/mock/mock.py", line 947, in assert_called_once_with
    raise AssertionError(msg)
AssertionError: Expected 'factory_method' to be called once. Called 2 times.

[Renat Akhmerov (rakhmerov)]

Может у нас по ошибке в тестах больше одного скедулера запускается?

Sent from Renat's iPad

> 29 сент. 2015 г., в 17:32, Nikolay Makhotkin <email address hidden> написал(а):
>
> Not only the one test fails. test_scheduler_with_factory,
> test_scheduler_without_factory also fail once in a while. But these
> tests don't assume we have multi instance scheduler. Here is a
> concurrency problem.
>
> ======================================================================
> FAIL: mistral.tests.unit.services.test_scheduler.SchedulerServiceTest.test_scheduler_without_factory
> tags: worker-2
> ----------------------------------------------------------------------
> Empty attachments:
> pythonlogging:''
> stderr
> stdout
>
> Traceback (most recent call last):
> File "/home/kolyan/projects/mistral/.tox/py27/local/lib/python2.7/site-packages/mock/mock.py", line 1305, in patched
> return func(*args, **keywargs)
> File "mistral/tests/unit/services/test_scheduler.py", line 119, in test_scheduler_without_factory
> method.assert_called_once_with(name='task', id='321')
> File "/home/kolyan/projects/mistral/.tox/py27/local/lib/python2.7/site-packages/mock/mock.py", line 947, in assert_called_once_with
> raise AssertionError(msg)
> AssertionError: Expected 'factory_method' to be called once. Called 2 times.
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1497269
>
> Title:
> test_scheduler_multi_instance fails once in a while
>
> Status in Mistral:
> Incomplete
> Status in Mistral liberty series:
> Incomplete
>
> Bug description:
> http://logs.openstack.org/59/222159/7/gate/gate-mistral-
> python27/6e11234/testr_results.html.gz
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mistral/+bug/1497269/+subscriptions

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/229845

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/229845
Committed: https://git.openstack.org/cgit/openstack/mistral/commit/?id=0420bbd86fe53a66c9da8e8256bdd97817ffe894
Submitter: Jenkins
Branch: master

commit 0420bbd86fe53a66c9da8e8256bdd97817ffe894
Author: Nikolay Mahotkin <email address hidden>
Date: Mon Sep 28 16:31:23 2015 +0300

    Fixing scheduler tests

     * Don't instantinate more unneeded schedulers
     * Create separate target method

    Related-Bug: #1497269

    Change-Id: I52234f044111bd26eaa9217ea73dbe39c5227d94

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/liberty
Review: https://review.openstack.org/233965

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/233965
Committed: https://git.openstack.org/cgit/openstack/mistral/commit/?id=d8fe7927cb0416a4116487d388f53476550b33b0
Submitter: Jenkins
Branch: stable/liberty

commit d8fe7927cb0416a4116487d388f53476550b33b0
Author: Nikolay Mahotkin <email address hidden>
Date: Mon Sep 28 16:31:23 2015 +0300

    Fixing scheduler tests

     * Don't instantinate more unneeded schedulers
     * Create separate target method

    Related-Bug: #1497269

    Change-Id: I52234f044111bd26eaa9217ea73dbe39c5227d94
    (cherry picked from commit 0420bbd86fe53a66c9da8e8256bdd97817ffe894)