The dep-8 test of iscsitarget should check the kernel module as well

Bug #1496057 reported by Stefan Bader
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
iscsitarget (Ubuntu)
Fix Released
Medium
Stefan Bader
Trusty
Fix Released
Medium
Stefan Bader

Bug Description

Right now the dep-8 test checks whether the daemon can be started. Practically the daemon can, even without the dkms kernel module available, though it makes not that much sense as for being useful this is also required. The module is already build but the outcome of that stage is not verified.

Make this more useful by modprobing the module as part of the test.

Stefan Bader (smb)
Changed in iscsitarget (Ubuntu):
assignee: nobody → Stefan Bader (smb)
importance: Undecided → Medium
status: New → In Progress
Stefan Bader (smb)
description: updated
Changed in iscsitarget (Ubuntu Trusty):
assignee: nobody → Stefan Bader (smb)
importance: Undecided → Medium
status: New → In Progress
Chris J Arges (arges)
Changed in iscsitarget (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package iscsitarget - 1.4.20.3+svn502-2ubuntu2

---------------
iscsitarget (1.4.20.3+svn502-2ubuntu2) wily; urgency=low

  * Fix the compat-3.13.patch to not touch the top-level makefile. Will
    allow to backport this version into older (kernel 3.13 and older)
    releases (LP: #1483415).
  * Add a check for the DKMS kernel module to d/tests/daemon dep-8 test
    (LP: #1496057)

 -- Stefan Bader <email address hidden> Wed, 16 Sep 2015 13:28:21 +0200

Changed in iscsitarget (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Stefan, or anyone else affected,

Accepted iscsitarget into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/iscsitarget/1.4.20.3+svn499-0ubuntu2.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in iscsitarget (Ubuntu Trusty):
status: In Progress → Fix Committed
tags: added: verification-needed
Revision history for this message
Stefan Bader (smb) wrote :

The dep-8 adt testing now completed for 3.13 and 3.19 kernels in Trusty. The module was test loaded for both combinations.

tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package iscsitarget - 1.4.20.3+svn499-0ubuntu2.1

---------------
iscsitarget (1.4.20.3+svn499-0ubuntu2.1) trusty; urgency=low

  * Backport compat changes to allow DKMS compiles for kernels up to 3.19
    (LP: #1483415).
    - d/p/fix-build-3.19: Modifies source to compile with 3.19
    - d/p/add-compat-3.19: Adds compat patches without enabling them
    - d/p/enable-compat-3.19: Enables compat patches in the DKMS config
  * Add a check for the DKMS kernel module to d/tests/daemon dep-8 test
    (LP: #1496057)

 -- Stefan Bader <email address hidden> Wed, 16 Sep 2015 13:29:48 +0200

Changed in iscsitarget (Ubuntu Trusty):
status: Fix Committed → Fix Released
Revision history for this message
Chris Halse Rogers (raof) wrote : Update Released

The verification of the Stable Release Update for iscsitarget has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.