Bagpipe driver: test Neutron registry callbacks

Bug #1493901 reported by Thomas Morin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
networking-bgpvpn
Fix Released
Medium
Thomas Morin

Bug Description

We need a test to detect any possible change in the signatures of Neutron registry callbacks.

The test would load ML2, create a port and check that the bagpipe driver callbacks are called with the expected signatures.

Changed in bgpvpn:
importance: Undecided → Medium
no longer affects: bgpvpn/liberty
Changed in bgpvpn:
status: New → Confirmed
assignee: nobody → Thomas Morin (tmmorin-orange)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to networking-bgpvpn (master)

Fix proposed to branch: master
Review: https://review.openstack.org/249081

Changed in bgpvpn:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to networking-bgpvpn (master)

Reviewed: https://review.openstack.org/249081
Committed: https://git.openstack.org/cgit/openstack/networking-bgpvpn/commit/?id=2aebe3da2d16578574ab8f8c2a86aeafdd16c0ca
Submitter: Jenkins
Branch: master

commit 2aebe3da2d16578574ab8f8c2a86aeafdd16c0ca
Author: Thomas Morin <email address hidden>
Date: Tue Nov 24 09:51:47 2015 +0100

    bagpipe: port delete action on BEFORE_DELETE event

    Details on the issue in bug #1517480.

    We need to subscribe to port before_delete events, because
    on after_delete events the port is already removed from the db
    and we can't retrieve the binding:host_id information (which
    is not passed in the event either).

    This change also include a unit test against this bug, which also
    happens to go through the ML2 RPC-to-registry codepaths so that
    the effect of real registry events against our code are tested, thus
    testing the validity of the expectation that the bagpipe driver code
    has against ML2. This addresses bug #1493901.

    One test is not passing, and thus commented out: see bug 1519258.

    Closes-Bug: 1517480
    Closes-Bug: 1493901

    Change-Id: Icce89d98bcc4424529dcbe661fed3c1c8191418c

Changed in bgpvpn:
status: In Progress → Fix Committed
Changed in bgpvpn:
milestone: none → liberty
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to networking-bgpvpn (backport/kilo)

Fix proposed to branch: backport/kilo
Review: https://review.openstack.org/251780

Changed in bgpvpn:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.