Add support for domain names in multiplayer

[Alex]

Currently in multiplayer mode domain names (such as openrails.example.com) aren't supported, only IP addresses. It seems like Open Rails isn't querying any DNS servers at all; a call to Dns.GetHostAddresses (http://bit.ly/1fUALuB) should fix this.

[Alex (pcuser42)]

I've had a play around and come up with some code that resolves this issue. It's my first time with C# in a while, and first time contributing to Open Rails, so comments and cleanups are welcome :)

[Carlo Santucci (carlosanit1)]

Thank you for the patch and I hope it's the first of a long series by you :) . Excuse my deep ignorance, but what is the advantage for OR of reaching domain names?

[Alex (pcuser42)]

Hi Carlo

For most users IP addresses frequently change, so adding the ability to resolve domain names allows these users to use a dynamic DNS service (such as No-IP) and never have to remember or look up their IP address. It would certainly come as a welcome addition to me, hence why I submitted the patch. :)

Alex

Sent from my phone

-----Original Message-----
From: "Carlo Santucci" <email address hidden>
Sent: ‎4/‎09/‎2015 8:20 a.m.
To: "<email address hidden>" <email address hidden>
Subject: [Bug 1491290] Re: Add support for domain names in multiplayer

Thank you for the patch and I hope it's the first of a long series by
you :) . Excuse my deep ignorance, but what is the advantage for OR of
reaching domain names?

--
You received this bug notification because you are subscribed to the bug
report.
https://bugs.launchpad.net/bugs/1491290

Title:
  Add support for domain names in multiplayer

Status in Open Rails:
  New

Bug description:
  Currently in multiplayer mode domain names (such as
  openrails.example.com) aren't supported, only IP addresses. It seems
  like Open Rails isn't querying any DNS servers at all; a call to
  Dns.GetHostAddresses (http://bit.ly/1fUALuB) should fix this.

To manage notifications about this bug go to:
https://bugs.launchpad.net/or/+bug/1491290/+subscriptions

[Carlo Santucci (carlosanit1)]

How can I test the patch (even if it is a very small patch)?

[Alex (pcuser42)]

One easy way is to start up a server on the LAN, then use the computer name (as seen in system properties; Windows+Pause) in place of the IP address. The patch works for local PCs too. :)

Alex

Sent from my phone

-----Original Message-----
From: "Carlo Santucci" <email address hidden>
Sent: ‎4/‎09/‎2015 7:20 p.m.
To: "<email address hidden>" <email address hidden>
Subject: [Bug 1491290] Re: Add support for domain names in multiplayer

How can I test the patch (even if it is a very small patch)?

--
You received this bug notification because you are subscribed to the bug
report.
https://bugs.launchpad.net/bugs/1491290

Title:
  Add support for domain names in multiplayer

Status in Open Rails:
  New

Bug description:
  Currently in multiplayer mode domain names (such as
  openrails.example.com) aren't supported, only IP addresses. It seems
  like Open Rails isn't querying any DNS servers at all; a call to
  Dns.GetHostAddresses (http://bit.ly/1fUALuB) should fix this.

To manage notifications about this bug go to:
https://bugs.launchpad.net/or/+bug/1491290/+subscriptions

[Carlo Santucci (carlosanit1)]

I could successfully test the patch both with local and remote server. Patch committed in x.3242. Thank you Alex.

[Cédric GNIEWEK (sharpeserana)]

This patch works with domain names... but IP addresses do not work anymore.

[Carlo Santucci (carlosanit1)]

I have just successfully tested a connection of two instances of OR within my computer using as exterbak server the tsimserver and inserting as string 74.50.121.15:20666 .

[Carlo Santucci (carlosanit1)]

exterbak = external

[Cédric GNIEWEK (sharpeserana)]

More information :
Using local IP address : Works
Using domain name : Works
Using public IP address : Error

Warning: System.Net.Sockets.SocketException: Hôte inconnu (=> Unknown host)
   at System.Net.Dns.GetAddrInfo(String name)
   at System.Net.Dns.InternalGetHostByAddress(IPAddress address, Boolean includeIPv6, Boolean throwOnFailure)
   at System.Net.Dns.GetHostEntry(String hostNameOrAddress)
   at ORTS.MultiPlayer.ClientComm..ctor(String serverIP, Int32 serverPort, String s) in e:\Documents\Coding\Jenkins\jobs\Open Rails Unstable\workspace\Source\RunActivity\MultiPlayer\ClientComm.cs:line 51
   at ORTS.Processes.GameStateRunActivity.InitSimulator(UserSettings settings, String[] args, String mode, String acttype) in e:\Documents\Coding\Jenkins\jobs\Open Rails Unstable\workspace\Source\RunActivity\Processes\GameStateRunActivity.cs:line 946
   at ORTS.Processes.GameStateRunActivity.Start(UserSettings settings, String acttype, String[] args) in e:\Documents\Coding\Jenkins\jobs\Open Rails Unstable\workspace\Source\RunActivity\Processes\GameStateRunActivity.cs:line 274
   at ORTS.Processes.GameStateRunActivity.<>c__DisplayClass8.<Load>b__3() in e:\Documents\Coding\Jenkins\jobs\Open Rails Unstable\workspace\Source\RunActivity\Processes\GameStateRunActivity.cs:line 149
   at ORTS.Processes.GameStateRunActivity.Load() in e:\Documents\Coding\Jenkins\jobs\Open Rails Unstable\workspace\Source\RunActivity\Processes\GameStateRunActivity.cs:line 189
   at ORTS.Processes.LoaderProcess.Load() in e:\Documents\Coding\Jenkins\jobs\Open Rails Unstable\workspace\Source\RunActivity\Processes\LoaderProcess.cs:line 155
   at ORTS.Processes.LoaderProcess.DoLoad() in e:\Documents\Coding\Jenkins\jobs\Open Rails Unstable\workspace\Source\RunActivity\Processes\LoaderProcess.cs:line 136
   at ORTS.Processes.LoaderProcess.LoaderThread() in e:\Documents\Coding\Jenkins\jobs\Open Rails Unstable\workspace\Source\RunActivity\Processes\LoaderProcess.cs:line 107
   at System.Threading.ThreadHelper.ThreadStart_Context(Object state)
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Threading.ThreadHelper.ThreadStart()

Connection error - will play in single mode.

[Cédric GNIEWEK (sharpeserana)]

And connection using public IP address worked before this patch.

[Carlo Santucci (carlosanit1)]

As written above, testing with public IP address 74.50.121.15 worked. However I don't want to create obstacles and I reverted the patch in release x.3247. A comment on this by Alex would be welcome.

[Carlo Santucci (carlosanit1)]

Obviously I mean that testing with public IP address 74.50.121.15 worked in release x.3242.

[Alex (pcuser42)]

Using release X3244, I could successfully connect to my local session with both the local IP address and local host name, and the public IP address 74.50.121.15 without issue.

[Alex (pcuser42)]

I've included an updated patch that tries to parse the IP address as it did before, and only then calls the DNS if that fails.

[Carlo Santucci (carlosanit1)]

That's my experience too. Cédric, can you confirm that with x.3247 or following ones you can now connect to a site you couldn't connect with release x.3242-x.3246? Can you provide the IP address of such site?

[Carlo Santucci (carlosanit1)]

Thanks Alex. Cédric, could you test Alex' patch with your test case before I commit it?

[Cédric GNIEWEK (sharpeserana)]

Hi,

This new patch works perfectly.
Thank you !

[Cédric GNIEWEK (sharpeserana)]

And, by the way, when I am playing with my friends, we're not using tsimserver but a direct connection to my server.

[Carlo Santucci (carlosanit1)]

Re-fixed in x.3251. Thank you, Alex.