SAML Update user details on login option creating new email artefact on every login
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mahara |
Fix Released
|
High
|
Robert Lyon | ||
1.10 |
Fix Released
|
High
|
Unassigned | ||
1.9 |
Fix Released
|
High
|
Unassigned | ||
15.04 |
Fix Released
|
High
|
Unassigned |
Bug Description
Mahara version: 15.04.1
Issue: When a user logs in via SAML and the configuration option is set to update the user's details then a new email artefact is created every time.
I think I have traced the problem
saml/lib.php line #234 calls set_profile_
lib/user.php lines #511-516 are a try{} in which $email = artefact_
This fails with the message "This artefact type is not a 'singular' artefact type" and so a new email artefact is created.
It will always fail because artefact/
class ArtefactTypeEmail extends ArtefactTypePro
public static function is_singular() {
return false;
}
description: | updated |
Changed in mahara: | |
assignee: | nobody → Robert Lyon (robertl-9) |
milestone: | none → 15.10.0 |
importance: | Undecided → High |
status: | New → In Progress |
Changed in mahara: | |
status: | In Progress → Fix Committed |
no longer affects: | mahara/15.10 |
Changed in mahara: | |
status: | Fix Committed → Fix Released |
Patch for "master" branch: https:/ /reviews. mahara. org/5161