Noises from CX20722 codec after reboot
Bug #1487345 reported by
David Henningsson
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
HWE Next |
Fix Released
|
Undecided
|
David Henningsson | ||
linux (Ubuntu) |
Fix Released
|
Undecided
|
David Henningsson |
Bug Description
This bug is meant for tracking purposes. Please do not triage.
On shutdown/reboot of CX20722, first shut down all EAPDs, then
shut down the afg node to D3.
Failure to do so can lead to spurious noises from the internal speaker
directly after reboot (and before the codec is reinitialized again, such as in BIOS setup or GRUB menus).
Changed in linux (Ubuntu): | |
status: | In Progress → Fix Committed |
Changed in hwe-next: | |
assignee: | nobody → David Henningsson (diwic) |
status: | New → Fix Committed |
Changed in hwe-next: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
On shutdown/reboot of CX20722, first shut down all EAPDs, then
shut down the afg node to D3.
Failure to do so can lead to spurious noises from the internal speaker
directly after reboot (and before the codec is reinitialized again, i e
in BIOS setup or GRUB menus).
BugLink: https:/ /bugs.launchpad .net/bugs/ 1487345 pci/hda/ patch_conexant. c | 23 +++++++ +++++++ +++++++ +-
Signed-off-by: David Henningsson <email address hidden>
---
sound/
1 file changed, 22 insertions(+), 1 deletion(-)
diff --git a/sound/ pci/hda/ patch_conexant. c b/sound/ pci/hda/ patch_conexant. c pci/hda/ patch_conexant. c pci/hda/ patch_conexant. c
index f788a91..ca03c40 100644
--- a/sound/
+++ b/sound/
@@ -200,12 +200,33 @@ static int cx_auto_init(struct hda_codec *codec)
return 0;
}
-#define cx_auto_free snd_hda_gen_free reboot_ notify( struct hda_codec *codec) >core.vendor_ id != 0x14f150f2) turn_eapd( codec, spec->num_eapds, spec->eapds, false); codec_set_ power_to_ all(codec, codec->core.afg, AC_PWRST_D3); codec_write( codec, codec->core.afg, 0, SET_POWER_ STATE, AC_PWRST_D3); reboot_ notify( codec); gen_free( codec);
+static void cx_auto_
+{
+ struct conexant_spec *spec = codec->spec;
+
+ if (codec-
+ return;
+
+ /* Turn the CX20722 codec into D3 to avoid spurious noises
+ from the internal speaker during (and after) reboot */
+ cx_auto_
+
+ snd_hda_
+ snd_hda_
+ AC_VERB_
+}
+
+static void cx_auto_free(struct hda_codec *codec)
+{
+ cx_auto_
+ snd_hda_
+}
static const struct hda_codec_ops cx_auto_patch_ops = { build_controls, gen_build_ pcms, reboot_ notify, jack_unsol_ event,
.build_controls = cx_auto_
.build_pcms = snd_hda_
.init = cx_auto_init,
+ .reboot_notify = cx_auto_
.free = cx_auto_free,
.unsol_event = snd_hda_
#ifdef CONFIG_PM
--
1.9.1