Move the "select" checkbox out of item heading in Inbox

Bug #1487306 reported by Jono M
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Low
Mason Warring

Bug Description

In the Inbox, all notifications have a "Select" checkbox as part of the panel header. This is wrapped in an <h4>, which causes screen readers such as JAWS to read out the checkbox strangely. It would be nice to make the panel header a <div> and have a heading inside it containing just the notification title.

Affects latest master

Changed in mahara:
assignee: nobody → Mason Warring (corgifan2)
Revision history for this message
Mason Warring (corgifan2) wrote :

Using Orca screen reader (I can't use JAWS, because Linux), the only weirdly read part of this page is the bulk actions button, all of the other bits I can tab to sound fine. However, the bulk actions bit sound like "Bulk actions collapsed geshmerton".

Revision history for this message
Mason Warring (corgifan2) wrote :

Changed the h4 on the notifications from <h4 class="panel-heading"> to <div class="panel-heading">, no problems as far as I can see. The page still reads fine with Orca screen reader.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/5927

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5927
Committed: https://git.mahara.org/mahara/mahara/commit/f28384143abb93b4daa59a7b502c4ffaeea9bd96
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit f28384143abb93b4daa59a7b502c4ffaeea9bd96
Author: Mason Warring <email address hidden>
Date: Tue Jan 19 15:38:12 2016 +1300

Bug #1487306 Notifcations changed <h4> to a <div>

In the modified file, I changed the <h4> for the user's incoming notfications into a div, because the <h4> was apparently causing issues with the JAWS screen reader (can't verify if this has been fixed, as I am on Linux), but with the <div> it works fine on Orca screen reader.

Added a css style to make the font-weight = 300 as it was before with <h4> tag

behatnotneeded

Change-Id: Ia99262a579b4733b406c8b2e608d480b6cb47262

Robert Lyon (robertl-9)
Changed in mahara:
milestone: none → 16.04.0
status: Confirmed → Fix Committed
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.