Incorrect label setup when creating custom layout

Bug #1486817 reported by Jono M
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Jono M
15.10
Fix Released
Undecided
Unassigned

Bug Description

Steps to reproduce

- "Edit layout" on any page
- Open "Create custom layout", change some stuff and click "Create new layout"
- Without refreshing the page, inspect the newly created radio button and its associated label

The radio button ID and label 'for' attribute don't match, and the label contains the text "100" instead of an accurate representation of the layout. If you refresh the page the label and radio button will be set up properly, so this only happens when the option is added with JavaScript.

Affects latest master

Jono M (jonom)
Changed in mahara:
status: Confirmed → In Progress
assignee: nobody → Jono Mingard (mingard)
importance: Low → Medium
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/5385

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5385
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/dc632ff8c3b3d3d0a045eeed1fae799e284d9b33
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit dc632ff8c3b3d3d0a045eeed1fae799e284d9b33
Author: Jono Mingard <email address hidden>
Date: Mon Sep 28 18:06:41 2015 +1300

Fix element attributes when creating custom layout (Bug #1486817)

Set up the label and radio button combination properly

Behat step needs to access the custom rows by id as fields all have
the same label

Change-Id: Ica93cbb1a33facee6770076f32b5abe23e9a2b36

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "15.10_STABLE" branch: https://reviews.mahara.org/5492

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5492
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/84082da3faf16c2bbe0a224f67dc12787090cb10
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.10_STABLE

commit 84082da3faf16c2bbe0a224f67dc12787090cb10
Author: Jono Mingard <email address hidden>
Date: Mon Sep 28 18:06:41 2015 +1300

Fix element attributes when creating custom layout (Bug #1486817)

Set up the label and radio button combination properly

Behat step needs to access the custom rows by id as fields all have
the same label

Change-Id: Ica93cbb1a33facee6770076f32b5abe23e9a2b36
(cherry picked from commit dc632ff8c3b3d3d0a045eeed1fae799e284d9b33)

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
milestone: none → 15.10.0
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.