Improper handling of errors extending share with generic driver

[Valeriy Ponomaryov]

If we try to extend share created with generic driver and Cinder does not have enough free space to extend its volume then we get error "Insufficient free space" in Cinder-volume service and Manila does not update share status right after it. It updates it only after timeout - 3 minutes.

Log from c-vol:

http://paste.openstack.org/show/413873/

Log from Manila:

http://paste.openstack.org/show/413885/

[Ben Swartzlander (bswartz)]

Ashok, what is your IRC handle? I wanted to discuss this bug and confirm that you plan to fix it by Liberty-RC1. If not, then we want to find another owner to make sure this gets fixed in Liberty.

[ashok chandran (ashok-chandran3)]

Hi Ben I am new to Manila. if this is urge nt please assign to someone else. I will look at some other bug.

Sent from my Mi phone
On Ben Swartzlander <email address hidden>, Sep 8, 2015 8:25 PM wrote:

Ashok, what is your IRC handle? I wanted to discuss this bug and confirm
that you plan to fix it by Liberty-RC1. If not, then we want to find
another owner to make sure this gets fixed in Liberty.

--
You received this bug notification because you are a bug assignee.
https://bugs.launchpad.net/bugs/1484857

Title:
  Improper handling of errors extending share with generic driver

Status in Manila:
  New

Bug description:
  If we try to extend share created with generic driver and Cinder does
  not have enough free space to extend its volume then we get error
  "Insufficient free space" in Cinder-volume service and Manila does not
  update share status right after it. It updates it only after timeout -
  3 minutes.

  Log from c-vol:

  http://paste.openstack.org/show/413873/

  Log from Manila:

  http://paste.openstack.org/show/413885/

To manage notifications about this bug go to:
https://bugs.launchpad.net/manila/+bug/1484857/+subscriptions
The information contained in this electronic message and any attachments to this message are intended for the exclusive use of the addressee(s) and may contain proprietary, confidential or privileged information. If you are not the intended recipient, you should not disseminate, distribute or copy this e-mail. Please notify the sender immediately and destroy all copies of this message and any attachments. WARNING: Computer viruses can be transmitted via email. The recipient should check this email and any attachments for the presence of viruses. The company accepts no liability for any damage caused by any virus transmitted by this email. www.wipro.com

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/223975

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/223975
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=f8f1fdc00ec39e0a18eeb83c0d090d9f69992e3d
Submitter: Jenkins
Branch: master

commit f8f1fdc00ec39e0a18eeb83c0d090d9f69992e3d
Author: Julia Varlamova <email address hidden>
Date: Wed Sep 16 04:53:04 2015 -0400

    Fix improper handling of extending error

    If we try to extend share created with generic driver and Cinder does not have
    enough free space to extend its volume then we get error "Insufficient
    free space". But Manila updates share status only after 3 minutes.

    Add check if volume status contains 'error' to '_wait_for_available_volume'
    function.

    Closes-bug: #1484857

    Change-Id: I1e206ec1c410c015a71f49e25ffa8e64b5870e64