Sometimes it's not clear why after clicking "Save and Proceed" the user sometimes stays on the original page

Bug #1484530 reported by Vitaly Kramskikh
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
Medium
Vitaly Kramskikh

Bug Description

STR:
1. Create an env, open the network tab
2. Change public IP range to 172.16.0.120 - 172.16.0.130
3. Navigate to other tab
4. In the confirmation window click "Save and Proceed"

Expected result:
There is an explicit message that saving has failed

Actual result:
User stays on the networks tab, and after scrolling down, there is validation error which is not visible originally

description: updated
Revision history for this message
Kyrylo Romanenko (kromanenko) wrote :

It seems i have caught reason of this issue.
We should disable "Save and Proceed" when "Save" is disabled.
And "Save" button is disabled when we have some input validation errors.
I have met such kind of bug during testing of plugin settings: https://bugs.launchpad.net/fuel/+bug/1501807

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/232502

Changed in fuel:
assignee: Fuel UI Team (fuel-ui) → Vitaly Kramskikh (vkramskikh)
status: Confirmed → In Progress
Changed in fuel:
status: In Progress → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/232622

Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/232622
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=220a5ea10160c219bea7701981f28d08e78e780e
Submitter: Jenkins
Branch: master

commit 220a5ea10160c219bea7701981f28d08e78e780e
Author: Vitaly Kramskikh <email address hidden>
Date: Thu Oct 8 22:42:50 2015 +0700

    Improve saving confirmation dialog

    - If there is validation error, do not allow to save changes
    - If saving failed, show error message instead of closing
      the dialog silently

    Change-Id: I4e849d21eca429b7bd3b9ad0edeb6e3d4113f855
    Closes-Bug: #1484530

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
Anastasia Palkina (apalkina) wrote :

Verified on ISO #141

{"fuel-createmirror_sha": "df6a93f7e2819d3dfa600052b0f901d9594eb0db", "api": "1.0", "fuelmain_sha": "3303f41f99cf9167da01d503dd5d2c8dab141447", "astute_sha": "a090546d43c770ac27ca81c6f8c78ff0ba4a93e0", "fuel-ostf_sha": "983d0e6fe64397d6ff3bd72311c26c44b02de3e8", "openstack_version": "2015.1.0-8.0", "build_id": "141", "build_number": "141", "auth_required": true, "fuel-library_sha": "cd1b4b67d2b00fb10264d6626327688b170f0bf8", "fuel-nailgun-agent_sha": "08e0a11cf1f29b705e4b910d9b9db5e9b708b6e3", "fuel-nailgun_sha": "1479c0b03ad928f2ea2a819fbf8218cff32e51b9", "fuel-agent_sha": "cf699820fb0a4d20bef001861e006dc9797b5733", "production": "docker", "python-fuelclient_sha": "769df968e19d95a4ab4f12b1d2c76d385cf3168c", "feature_groups": ["mirantis"], "release": "8.0", "release_versions": {"2015.1.0-8.0": {"VERSION": {"fuel-createmirror_sha": "df6a93f7e2819d3dfa600052b0f901d9594eb0db", "api": "1.0", "fuelmain_sha": "3303f41f99cf9167da01d503dd5d2c8dab141447", "astute_sha": "a090546d43c770ac27ca81c6f8c78ff0ba4a93e0", "fuel-ostf_sha": "983d0e6fe64397d6ff3bd72311c26c44b02de3e8", "openstack_version": "2015.1.0-8.0", "build_id": "141", "build_number": "141", "fuel-library_sha": "cd1b4b67d2b00fb10264d6626327688b170f0bf8", "fuel-nailgun-agent_sha": "08e0a11cf1f29b705e4b910d9b9db5e9b708b6e3", "fuel-nailgun_sha": "1479c0b03ad928f2ea2a819fbf8218cff32e51b9", "fuel-agent_sha": "cf699820fb0a4d20bef001861e006dc9797b5733", "production": "docker", "python-fuelclient_sha": "769df968e19d95a4ab4f12b1d2c76d385cf3168c", "feature_groups": ["mirantis"], "release": "8.0"}}}

Changed in fuel:
status: Fix Committed → Fix Released
Dmitry Pyzhov (dpyzhov)
tags: added: area-ui
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.