Lightdm (and GDM) source .profile as bash, indirectly sourcing .bashrc

[Murukesh Mohanan]

The fix for https://bugs.launchpad.net/ubuntu/+source/gdm/+bug/678421 leads to `.profile` being sourced by bash instead of dash. This leads `.bashrc` being sourced indirectly via .profile. IMHO, `.bashrc` should not be sourced even *once* in this situation. I suggest that sourcing .profile actually be done with BASH_VERSION unset:

    BASH_VERSION= . "$CONFIG"

At the very least, a check should be done whether bash is the user's login shell. It can be done thus:

    [ "$SHELL" != "/bin/bash" ] && BASH_VERSION=
    . "$CONFIG"

utilizing `$SHELL` given it stores the login shell (http://unix.stackexchange.com/questions/45458/why-shell-doesnt-change-when-i-run-new-shell).

[Gunnar Hjalmarsson (gunnarhj)]

Thanks for your report, Muru.

Even if the default ~/.bashrc is protected from being run through a test at the top of the file, I think this will take care of a few cases where users with custom configuration have been somewhat confused.

[Gunnar Hjalmarsson (gunnarhj)]

Subscribed ubuntu-sponsors, since the GDM MP doesn't show up in the queue for some reason.

[Launchpad Janitor (janitor)]

This bug was fixed in the package gdm - 3.16.2-0ubuntu2

---------------
gdm (3.16.2-0ubuntu2) wily; urgency=medium

  * debian/patches/ubuntu_config_error_dialog.patch:
    Prevent that ~/.bashrc is sourced when ~/.profile is sourced
    (LP: #1482641).

 -- Gunnar Hjalmarsson <email address hidden> Fri, 07 Aug 2015 17:23:00 +0200

[Murukesh Mohanan (murukesh)]

Presumably this isn't important enough to make an SRU, right, Gunnar?

[Gunnar Hjalmarsson (gunnarhj)]

Given that first command in the default .bashrc, I don't think an SRU is motivated either.

[Launchpad Janitor (janitor)]

This bug was fixed in the package lightdm - 1.15.2-0ubuntu2

---------------
lightdm (1.15.2-0ubuntu2) wily; urgency=medium

  * debian/control:
    - Add build-depends on valac

 -- Robert Ancell <email address hidden> Mon, 10 Aug 2015 16:38:04 +1200