Mahara

Reword block position selection combobox

Bug #1482473 reported by Jono M
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Low
Sarah Cotton
Mahara 16.04.0
15.10
Fix Released
Low
Unassigned
Mahara 15.10.3

Bug Description

When positioning a block using the keyboard (after clicking on one of the block type buttons), the default option in the "Position" combobox is "Top of column". That's not strictly correct, however, and if there are multiple rows in a page it becomes confusing - "Top of cell" would be a better description IMO.

Affects latest master

Kristina Hoeppner (kris-hoeppner)
Changed in mahara:
assignee: nobody → Sarah Cotton (sarah-cotton)
milestone: none → 16.04.0
status: New → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/5713

Revision history for this message
Sarah Cotton (sarah-cotton) wrote :

Not sure why package.json was included in the submission, I thought I'd removed it; please ignore/remove if possible.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5713
Committed: https://git.mahara.org/mahara/mahara/commit/9e665299537d7fc1c756d544311c3b3b78c9865d
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 9e665299537d7fc1c756d544311c3b3b78c9865d
Author: Sarah Cotton <email address hidden>
Date: Fri Nov 13 09:13:53 2015 +0000

Changed 'column' to 'cell' in dropdown (Bug #1482473)

behatnotneeded

Change-Id: Iffe40a00d119efca936a40500b762a625e5f348a

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "15.10_STABLE" branch: https://reviews.mahara.org/6320

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/6320
Committed: https://git.mahara.org/mahara/mahara/commit/e3859b7719f44be4e08230747f4754c704f356a1
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.10_STABLE

commit e3859b7719f44be4e08230747f4754c704f356a1
Author: Sarah Cotton <email address hidden>
Date: Fri Nov 13 09:13:53 2015 +0000

Changed 'column' to 'cell' in dropdown (Bug #1482473)

behatnotneeded

Change-Id: Iffe40a00d119efca936a40500b762a625e5f348a

Kristina Hoeppner (kris-hoeppner)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.