blktap-dkms FTBS on kernels >= 4.1

[Tim Gardner]

commit 11d83360452ea2a95e699da01f8e1bcc4676a5de (mm, mempool: do not allow atomic resizing) in Linux 4.1 changed the function prototype for mempool_resize() by dropping the memory allocation flags parameter.

Add this code to request.c:

+#if LINUX_VERSION_CODE >= KERNEL_VERSION(4, 1, 0)
+ err = mempool_resize(bufs, target);
+#else
  err = mempool_resize(bufs, target, GFP_KERNEL);
+#endif

Without this code the DKMS package will not build against the Wily LTS backport kernel.

[Adam Conrad (adconrad)]

Hello Tim, or anyone else affected,

Accepted blktap-dkms into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/blktap-dkms/2.0.93-0.3ubuntu4~14.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Tim Gardner (timg-tpi)]

Looks like this isn't going to work with a 3.13 kernel.

/var/lib/dkms/blktap/2.0.93/build/ring.c: In function ‘blktap_ring_make_tr_request’:
/var/lib/dkms/blktap/2.0.93/build/ring.c:314:32: error: ‘struct bio’ has no member named ‘bi_iter’
  breq->u.tr.sector_number = bio->bi_iter.bi_sector;
                                ^

[Tim Gardner (timg-tpi)]

Uploaded 2.0.93-0.3ubuntu4~14.04.2 from Stefan Bader to fix the compile issue on 3.13.

[Martin Pitt (pitti)]

Hello Tim, or anyone else affected,

Accepted blktap-dkms into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/blktap-dkms/2.0.93-0.3ubuntu6~14.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Martin Pitt (pitti)]

Hello Tim, or anyone else affected,

Accepted blktap-dkms into vivid-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/blktap-dkms/2.0.93-0.3ubuntu6~15.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Adam Conrad (adconrad)]

Verified on vivid against 3.19.0-25-generic

[Adam Conrad (adconrad)]

Verified on trusty against 3.19.0-25-generic, 3.16.0-45-generic, and 3.13.0-59-generic

[Launchpad Janitor (janitor)]

This bug was fixed in the package blktap-dkms - 2.0.93-0.3ubuntu6~14.04.1

---------------
blktap-dkms (2.0.93-0.3ubuntu6~14.04.1) trusty; urgency=medium

  * debian/rules: Stop recommending kernel headers, our DKMS packages
    shouldn't do this, as we have no way of matching installed kernel.

blktap-dkms (2.0.93-0.3ubuntu5) wily; urgency=low

  * Added compat code to avoid use of bio->bi_iter for kernels <3.14
    the Debian change that came with 2.0.93-0.3 did not bother about
    older kernels (fixup for LP: #1477718).

 -- Adam Conrad <email address hidden> Tue, 28 Jul 2015 23:25:07 -0600

[Adam Conrad (adconrad)]

The verification of the Stable Release Update for blktap-dkms has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package blktap-dkms - 2.0.93-0.3ubuntu6~15.04.1

---------------
blktap-dkms (2.0.93-0.3ubuntu6~15.04.1) vivid; urgency=medium

  * debian/rules: Stop recommending kernel headers, our DKMS packages
    shouldn't do this, as we have no way of matching installed kernel.

blktap-dkms (2.0.93-0.3ubuntu5) wily; urgency=low

  * Added compat code to avoid use of bio->bi_iter for kernels <3.14
    the Debian change that came with 2.0.93-0.3 did not bother about
    older kernels (fixup for LP: #1477718).

blktap-dkms (2.0.93-0.3ubuntu4) wily; urgency=medium

  * Substituted linux-any for the list of architectures.

blktap-dkms (2.0.93-0.3ubuntu3) wily; urgency=medium

  * Add patch to support kernels >= 4.1
    debian/patches/Version-dependent-compilation.patch

 -- Adam Conrad <email address hidden> Tue, 28 Jul 2015 23:25:07 -0600