Show collections in "Shared with me" screen

[Aaron Wells]

Similar to Bug 1476491 & Bug 1476492, the idea here is that we'd show collections on the "Shared with me" screen. (Currently it only shows pages, and each collection for each page is listed individually).

This one is a little bit trickier than the other two bugs, because of the search bar. Presumably you'd still want to be searching the individual pages as well as whole collections, in which case it might make sense to show individual pages as well as the collections they belong to...

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/5000

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/5001

[Aaron Wells (u-aaronw)]

1. Create collections C1, and C2.
2. Create pages P1A, P1B, P2A, P2B, P2C, P4, P5
3. Put pages P1A & P1B into Collection C1
4. Put pages P2A, P2B, P2C into Collection C1
5. Write a comment "I am on P1A" on P1A.
6. Write a comment "I am on P1B" on P1B.
7. Write a comment "I am on P4" on P4.
8. Share all these pages with another user.
9. Log in as the other user, and go to the "Portfolio -> Shared with me" page.5. View the "Latest pages" block on your dashboard

Expected result: You should see "C1 (2 pages)", "C2 (3 pages)", P4, and P5 on your list of pages shared with you. For the most recent comment, you should see "I am on P1B" for C1, "I am on P4" for P4, and no comment for C2 and P5.

[Aaron Wells (u-aaronw)]

Um, ignore that "5. View the "Latest pages" block on your dashboard" in the previous comment. I had copy-pasted the basic test plan from another bug and forgot to delete that part. :)

[Jinelle Foley-Barnes (jinelleb)]

I paused the Behat test so we could figure out where it was breaking. This what the screen was showing.

[Aaron Wells (u-aaronw)]

Hi Jinelle, that error was due to a typo in the parent bug that expanded view_search(). I've fixed that now.

[Jinelle Foley-Barnes (jinelleb)]

Nice!!! Good find!

I'll re test it now :)

Cheers,
Jinelle

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/5000
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/462b1c471c851c1093797f99fbc2bc798c396c3a
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit 462b1c471c851c1093797f99fbc2bc798c396c3a
Author: Aaron Wells <email address hidden>
Date: Mon Jul 20 19:39:17 2015 +1200

Refactoring SQL query in View::shared_to_user() (Bug 1476495)

The old one unnecessarily used two separate queries for Postgres
& MySQL. And it had a bug in how it used MySQL's extended
"GROUP BY" functionality. While MySQL does let you return
non-aggregated columns, it uses an arbitrary record for these of
them, NOT the first record according to ORDER BY.

Also restructured the query a bit for optimization purposes.

behatnotneeded (Test in subsequent patch)

Change-Id: I3d49292025dcf7ac510a84d7e800476defec0525

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/5001
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/0958d6c0c762415632854dd3499479667de213f0
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit 0958d6c0c762415632854dd3499479667de213f0
Author: Aaron Wells <email address hidden>
Date: Tue Jul 21 16:22:04 2015 +1200

Support for collections in "Shared with me" screen (Bug 1476495)

Change-Id: Ieff8ebae03f6cfb68ea2dd3295f8882910467afb

[Kristina Hoeppner (kris-hoeppner)]

This feature is sponsored by Pratt Institute in Brooklyn, NY. Thank you very much.